From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 3/4] ACPI: thinkpad-acpi: disable backlight handler if ACPI generic could do it Date: Tue, 9 Oct 2007 14:34:41 +0100 Message-ID: <20071009133441.GA4689@srcf.ucam.org> References: <1191849179-24087-1-git-send-email-hmh@hmh.eng.br> <1191849179-24087-4-git-send-email-hmh@hmh.eng.br> <1191910875.9847.79.camel@queen.suse.de> <20071009075914.GA790@srcf.ucam.org> <1191918351.9847.132.camel@queen.suse.de> <20071009083336.GA1099@srcf.ucam.org> <1191923208.9847.169.camel@queen.suse.de> <20071009100418.GA2472@srcf.ucam.org> <20071009111445.GB24946@khazad-dum.debian.net> <1191936552.9847.257.camel@queen.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([78.32.9.130]:50281 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbXJINe6 (ORCPT ); Tue, 9 Oct 2007 09:34:58 -0400 Content-Disposition: inline In-Reply-To: <1191936552.9847.257.camel@queen.suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Renninger Cc: Henrique de Moraes Holschuh , Len Brown , ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org On Tue, Oct 09, 2007 at 03:29:12PM +0200, Thomas Renninger wrote: > static const struct acpi_device_id dummy_vid_device_ids[] = { > {"LNXVIDEO", 0}, > {"", 0}, > }; No. This will match if any of the video extension is implemented. We only want it to match if backlight control is implemented. There are plenty of Thinkpads that implement a subset of the video extension but still need backlight control to be handled via the Thinkpad-specific routes. -- Matthew Garrett | mjg59@srcf.ucam.org