From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
Cc: linux-acpi <linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
ibm-acpi-devel
<ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] Untested proposal patch: Store video capabilities of BIOS globally at ACPI parse time and export it.
Date: Mon, 15 Oct 2007 17:52:46 +0100 [thread overview]
Message-ID: <20071015165246.GB5021@srcf.ucam.org> (raw)
In-Reply-To: <1192466754.9847.594.camel-X8wR35IVlAxolqkO4TVVkw@public.gmane.org>
On Mon, Oct 15, 2007 at 06:45:53PM +0200, Thomas Renninger wrote:
> + if (ACPI_SUCCESS(acpi_get_handle(handle, "_BCM", &h_dummy1)) &&
> + ACPI_SUCCESS(acpi_get_handle(handle, "_BCL", &h_dummy2)) &&
> + ACPI_SUCCESS(acpi_get_handle(handle, "_BQC", &h_dummy3)))
> + acpi_video_support |= ACPI_VIDEO_BRIGHTNESS;
Probably want to check for _BCQ as an alternative to _BQC as well.
> + return 0;
Why return int if you always return 0? Other than that, it looks
reasonable (and saves us having copy and pasted code in all of the
hardware-specific drivers)
--
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-15 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 16:45 [PATCH] Untested proposal patch: Store video capabilities of BIOS globally at ACPI parse time and export it Thomas Renninger
[not found] ` <1192466754.9847.594.camel-X8wR35IVlAxolqkO4TVVkw@public.gmane.org>
2007-10-15 16:52 ` Matthew Garrett [this message]
2007-10-17 14:35 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015165246.GB5021@srcf.ucam.org \
--to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=trenn-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox