From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] Untested proposal patch: Store video capabilities of BIOS globally at ACPI parse time and export it. Date: Mon, 15 Oct 2007 17:52:46 +0100 Message-ID: <20071015165246.GB5021@srcf.ucam.org> References: <1192466754.9847.594.camel@queen.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1192466754.9847.594.camel-X8wR35IVlAxolqkO4TVVkw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ibm-acpi-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: ibm-acpi-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Thomas Renninger Cc: linux-acpi , ibm-acpi-devel List-Id: linux-acpi@vger.kernel.org On Mon, Oct 15, 2007 at 06:45:53PM +0200, Thomas Renninger wrote: > + if (ACPI_SUCCESS(acpi_get_handle(handle, "_BCM", &h_dummy1)) && > + ACPI_SUCCESS(acpi_get_handle(handle, "_BCL", &h_dummy2)) && > + ACPI_SUCCESS(acpi_get_handle(handle, "_BQC", &h_dummy3))) > + acpi_video_support |= ACPI_VIDEO_BRIGHTNESS; Probably want to check for _BCQ as an alternative to _BQC as well. > + return 0; Why return int if you always return 0? Other than that, it looks reasonable (and saves us having copy and pasted code in all of the hardware-specific drivers) -- Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/