Re: [PATCH]libata-acpi: add ACPI _PSx method

Shaohua Li
2007-11-05T01:18:55Z

On Sat, 2007-11-03 at 09:00 -0400, Jeff Garzik wrote:
> Shaohua Li wrote:
> > Not sure, this is just to call a BIOS routine, but a check should be
> > safer. Thanks!
> >
> > ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
> > methods. As recently most PATA drivers use libata, this patch adds _PSx
> > method support in libata. ACPI spec doesn't mention if SATA requires the
> > same _PSx method.
> >
> > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> > Acked-by: Len Brown <len.brown@intel.com>
>
>
> What is the safety factor on this patch? :)
Not sure, but it depends on BIOS, I just guess ignoring disabled device might be safe :)
> Since we are into 2.6.24-rc, my preference would be to let this get some
> testing in -mm, and push it upstream for 2.6.25. Comments?
Sure, Thanks, taking either this patch or previous patch is ok to me.

Thanks,
Shaohua