Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

[Andrew Morton]

On Sat,  8 Sep 2007 09:29:18 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=8995
> 
>            Summary: /proc/acpi/alarm worked; update to 2.6.22.2 and
>                     /sys/class/rtc/rtc0/wakealarm don't
>            Product: ACPI
>            Version: 2.5
>      KernelVersion: 2.6.22.2
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Power-Sleep-Wake
>         AssignedTo: acpi_power-sleep-wake@kernel-bugs.osdl.org
>         ReportedBy: huffcslists@gmail.com
> 
> 
> Most recent kernel where this bug did not occur:2.6.20
> Distribution: FC6
> Hardware Environment: ASUS A8N-SLI mobo, Athlon 64 3200+, PATA Disk
> Software Environment: FC6, MythTV 0.20.2-164
> Problem Description:
> Change in kernel code from support for /proc/acpi/alarm to
> /sys/class/rtc/rtc0/wakealarm and supporting code borked working system.  Will
> no longer wake at set time.
> Time set <> time reported by cat /sys.../wakealarm.  Return value off by large
> constant.  Note: Mobo doesn't support month, day, or year in alarm setting.
> 
> Steps to reproduce:
> Before upgrade from 2.6.20 to 2.6.22.2, suspend-to-disk with powerdown to
> standby would wake at time echoed into /proc/acpi/alarm.  Change of wakeup time
> setting code to echo 0 to /sys/class/rtc/rtc0/wakealarm followed by echo of
> seconds since epoch of desired wakeup time under 2.6.22.2 does not work. 
> System will not wake up at specified time.  Will wake by keyboard keystroke,
> such as Ctrl+Esc.  Tried enabling APM (BIOS) alarm setting and all entries
> under /proc/acpi/wakeup (all on at once), but no improvement.
> Test sequence:
> # echo 0 > /sys/class/rtc/rtc0/wakealarm
> # t=`date +%s`; w=`expr $t + 60`; echo $w > /sys/class/rtc/rtc0/wakealarm
> # echo $w
> 1189268800
> # cat /sys/class/rtc/rtc0/wakealarm
> 2076101696
> # expr 2076101696 - 1189268800
> 886832896
> <invoke your favorite code to suspend to disk and power down system leaving
> standby power on>
> <wait>
> <wait some more>
> <hit power on button>
> 

Guys, can we please work out where the problem lies here?  Is it in the 
new RTC code, ACPI or what?

Thanks.

Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

[Rafael J. Wysocki]

On Sunday, 9 September 2007 02:29, Andrew Morton wrote:
> On Sat,  8 Sep 2007 09:29:18 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:
> 
> > http://bugzilla.kernel.org/show_bug.cgi?id=8995
> > 
> >            Summary: /proc/acpi/alarm worked; update to 2.6.22.2 and
> >                     /sys/class/rtc/rtc0/wakealarm don't
> >            Product: ACPI
> >            Version: 2.5
> >      KernelVersion: 2.6.22.2
> >           Platform: All
> >         OS/Version: Linux
> >               Tree: Mainline
> >             Status: NEW
> >           Severity: normal
> >           Priority: P1
> >          Component: Power-Sleep-Wake
> >         AssignedTo: acpi_power-sleep-wake@kernel-bugs.osdl.org
> >         ReportedBy: huffcslists@gmail.com
> > 
> > 
> > Most recent kernel where this bug did not occur:2.6.20
> > Distribution: FC6
> > Hardware Environment: ASUS A8N-SLI mobo, Athlon 64 3200+, PATA Disk
> > Software Environment: FC6, MythTV 0.20.2-164
> > Problem Description:
> > Change in kernel code from support for /proc/acpi/alarm to
> > /sys/class/rtc/rtc0/wakealarm and supporting code borked working system.  Will
> > no longer wake at set time.
> > Time set <> time reported by cat /sys.../wakealarm.  Return value off by large
> > constant.  Note: Mobo doesn't support month, day, or year in alarm setting.
> > 
> > Steps to reproduce:
> > Before upgrade from 2.6.20 to 2.6.22.2, suspend-to-disk with powerdown to
> > standby would wake at time echoed into /proc/acpi/alarm.  Change of wakeup time
> > setting code to echo 0 to /sys/class/rtc/rtc0/wakealarm followed by echo of
> > seconds since epoch of desired wakeup time under 2.6.22.2 does not work. 
> > System will not wake up at specified time.  Will wake by keyboard keystroke,
> > such as Ctrl+Esc.  Tried enabling APM (BIOS) alarm setting and all entries
> > under /proc/acpi/wakeup (all on at once), but no improvement.
> > Test sequence:
> > # echo 0 > /sys/class/rtc/rtc0/wakealarm
> > # t=`date +%s`; w=`expr $t + 60`; echo $w > /sys/class/rtc/rtc0/wakealarm
> > # echo $w
> > 1189268800
> > # cat /sys/class/rtc/rtc0/wakealarm
> > 2076101696
> > # expr 2076101696 - 1189268800
> > 886832896
> > <invoke your favorite code to suspend to disk and power down system leaving
> > standby power on>
> > <wait>
> > <wait some more>
> > <hit power on button>
> > 
> 
> Guys, can we please work out where the problem lies here?  Is it in the 
> new RTC code, ACPI or what?

I think the suspend/hibernation code ordering changes after 2.6.20 are to blame
here.

Reportedly, the problem can be fixed by applying the patch from
http://lkml.org/lkml/2007/8/27/392 , but that requires some other changes which
are not present in 2.6.22.

It would be nice if that could be tested on 2.6.23-rc5 with the patchset from
http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.23-rc5/patches/ applied
and the patch from http://lkml.org/lkml/2007/8/27/392 on top of it.

Greetings,
Rafael

Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

[David Brownell]

Re http://bugzilla.kernel.org/show_bug.cgi?id=8995 ...

On Sunday 09 September 2007, Rafael J. Wysocki wrote:
> I think the suspend/hibernation code ordering changes after
> 2.6.20 are to blame here.

So what's the status of this now ... are we back to having
the /sys/class/rtc/rtc0/wakealarm work with ACPI again, with
/sys/power/state written as "standby", "mem", or "disk"

(At least on the systems where it used to work.  I've had
bad luck with ACPI wake on most systems.  So while it'd be
great to see it working everywhere, I'm just asking about
the regression here.)

- Dave

p.s. some folk may need the appended patch.

=====	CUT HERE
From: Mark Lord <lkml@rtr.ca>

This patch fixes rtc-cmos to ignore the two upper bits when reading
the BCD mday (day of month) register from CMOS.  Some systems (eg. mine)
seem to have the top bit set to "1" for some reason.

Signed-off-by: Mark Lord <mlord@pobox.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>

--- a/drivers/rtc/rtc-cmos.c	2007-11-03 16:24:09.000000000 -0400
+++ b/drivers/rtc/rtc-cmos.c	2007-11-03 16:26:51.000000000 -0400
@@ -120,7 +120,8 @@
 	t->time.tm_hour = CMOS_READ(RTC_HOURS_ALARM);
 
 	if (cmos->day_alrm) {
-		t->time.tm_mday = CMOS_READ(cmos->day_alrm);
+		/* ignore upper bits on readback per ACPI spec */
+		t->time.tm_mday = CMOS_READ(cmos->day_alrm) & 0x3f;
 		if (!t->time.tm_mday)
 			t->time.tm_mday = -1;
 

Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

[Rafael J. Wysocki]

On Sunday, 4 of November 2007, David Brownell wrote:
> Re http://bugzilla.kernel.org/show_bug.cgi?id=8995 ...
> 
> On Sunday 09 September 2007, Rafael J. Wysocki wrote:
> > I think the suspend/hibernation code ordering changes after
> > 2.6.20 are to blame here.
> 
> So what's the status of this now ... are we back to having
> the /sys/class/rtc/rtc0/wakealarm work with ACPI again, with
> /sys/power/state written as "standby", "mem", or "disk"

Yes, it should work now.

The fix for the "disk" case is in the mainline:

9cd9a0058dd35268b24fa16795a92c800f4086d4
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Thu Oct 18 03:04:56 2007 -0700

    Hibernation: Enter platform hibernation state in a consistent way.

Re: [Bugme-new] [Bug 8995] New: /proc/acpi/alarm worked; update to 2.6.22.2 and /sys/class/rtc/rtc0/wakealarm don't

[David Brownell]

On Sunday 04 November 2007, Rafael J. Wysocki wrote:
> On Sunday, 4 of November 2007, David Brownell wrote:
> >
> > So what's the status of this now ... are we back to having
> > the /sys/class/rtc/rtc0/wakealarm work with ACPI again
> 
> Yes, it should work now.

A current git kernel seemed to work for me on at least one
system that had previously misbehaved ... both "standby" and
"disk" suspend now let the wakealarm do its thing.  (And STR
has the usual unrelated framebuffer issues.)  And I'm told 
another person has seen it work again on his hardware.  I'll
try it on a few other systems too, just to be sure.

Thanks for the bugfix, and update!

- Dave