From: Andrew Morton <akpm@linux-foundation.org>
To: trenn@suse.de
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>, Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH 1/5] Small ACPICA extension to be able to store the name of operation regions in osl.c later
Date: Mon, 5 Nov 2007 22:58:40 -0800 [thread overview]
Message-ID: <20071105225840.610943fc.akpm@linux-foundation.org> (raw)
In-Reply-To: <1193236371.4590.228.camel@queen.suse.de>
this patch introduces a compile error:
drivers/acpi/osl.c:1203: error: conflicting types for 'acpi_os_validate_address'
include/acpi/acpiosxf.h:243: error: previous declaration of 'acpi_os_validate_address' was here
which the next patch fixes. This breaks git-bisection and will cause great
gnashing of teeth to those who hit it.
Also, please fix this:
drivers/acpi/osl.c: In function 'acpi_os_validate_address':
drivers/acpi/osl.c:1365: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'long unsigned int'
drivers/acpi/osl.c:1365: warning: format '%s' expects type 'char *', but argument 5 has type 'long unsigned int'
it's all covered in Documentation/SubmitChecklist but it seems that
file was write-only.
<goes back to fixing build errors>
prev parent reply other threads:[~2007-11-06 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 14:32 [PATCH 1/5] Small ACPICA extension to be able to store the name of operation regions in osl.c later Thomas Renninger
2007-11-06 6:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105225840.610943fc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox