Re: [PATCH 3/5, RFC] Introduce pci_slot

Matthew Wilcox
2007-11-13T20:03:33Z

On Tue, Nov 13, 2007 at 01:56:46PM -0600, Linas Vepstas wrote:
> On Mon, Nov 12, 2007 at 05:14:47PM -0700, Alex Chiang wrote:
> > +/* pci_slot represents a physical slot */
> > +struct pci_slot {
> > + struct pci_bus *bus; /* The bus this slot is on */
> > + struct pci_slot *next; /* Next slot on this bus */
> > + struct hotplug_slot *hotplug; /* Hotplug info (migrate over time) */
>
> How much migration do you expect? Some of it? All of it? If the
> answer is "all of it", wouldn't it just be easier to rename
> struct hotplug_slot, and go from there?

Only the bits that make sense for non-hotpluggable slots.

I tried your suggestion first. It wasn't much fun.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."