Re: [patch 7/8] ACPI: video - more cleanups

[Len Brown <lenb@kernel.org>]

On Wednesday 14 November 2007 02:18, Zhang Rui wrote:
> On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
> > ACPI: video - more cleanups
> > 
> > Remove unneeded checks and initializations, implement proper
> > unwinding after errors in initialization code, get rid of
> > unneeded casts, adjust formatting.
> A big patch with a large number of minor cleanups/fixes.
> Thanks for your work, Dmitry.
> I'm okay with this one except the comment below.
> 
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> 
> > @@ -1772,12 +1783,11 @@ static int acpi_video_bus_stop_devices(s
> >  static void acpi_video_bus_notify(acpi_handle handle, u32 event, void
> > *data)
> >  {
> >         struct acpi_video_bus *video = data;
> > -       struct acpi_device *device = NULL;
> > +       struct acpi_device *device;
> >         struct input_dev *input;
> >         int keycode;
> > 
> > -
> > -       printk("video bus notify\n");
> > +       printk(KERN_DEBUG "video bus notify\n");
> This debug message should be removed.

wups, yes I remember that one...
I'll delete that in .24 and queue the rest of Dmitry's cleanup for .25.

thanks,
-Len