From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Chiang Subject: Re: [PATCH 2/5] Construct one fakephp slot per pci slot Date: Thu, 15 Nov 2007 10:40:15 -0700 Message-ID: <20071115174015.GI7541@ldl.fc.hp.com> References: <20071114193605.GA25002@ldl.fc.hp.com> <20071114201246.GZ17785@parisc-linux.org> <20071114205555.GH25002@ldl.fc.hp.com> <200711151258.02696.eike-hotplug@sf-tec.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from palrel13.hp.com ([156.153.255.238]:52046 "EHLO palrel13.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758284AbXKORkS (ORCPT ); Thu, 15 Nov 2007 12:40:18 -0500 Content-Disposition: inline In-Reply-To: <200711151258.02696.eike-hotplug@sf-tec.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Rolf Eike Beer Cc: Matthew Wilcox , Gary Hade , Greg KH , gregkh@suse.de, kristen.c.accardi@intel.com, lenb@kernel.org, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, kaneshige.kenji@jp.fujitsu.com, pcihpd-discuss@lists.sourceforge.net, linux-acpi@vger.kernel.org * Rolf Eike Beer : > Am Mittwoch, 14. November 2007 schrieb Alex Chiang: > > * Matthew Wilcox : > > > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang > > > > Register one slot per slot, rather than one slot per > > > > function. Change the name of the slot to fake%d instead > > > > of the pci address. > > > > > > > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN > > > > > > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/, > > > then use SLOT_NAME_SIZE throughout? > > > > Whoops, good catch. I had a braino there. > > Just drop it and use sizeof(dslot->name) in snprintf(). Just be > careful not to use slot->name there as it would always be > sizeof(void*)! Thanks, even better. /ac