public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Len Brown <lenb@kernel.org>
Cc: ibm-acpi-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set
Date: Sat, 17 Nov 2007 18:15:01 -0200	[thread overview]
Message-ID: <20071117201501.GG30919@khazad-dum.debian.net> (raw)
In-Reply-To: <200711151314.12935.lenb@kernel.org>

On Thu, 15 Nov 2007, Len Brown wrote:
> > This patch:
> 
> a nit to prove that I read this before dumping it into my test branch...

Hey, I never doubted you read all my patchsets :-)

> the "perfect patch" never refers to itself as a patch
> in its check-in comments -- since by the time it is checked
> in, it is sort of self-evident it is a patch:-)

I will remember that one :-)

> but, Henrique, we're waxing about perfection here -- your
> patch hygene is already some of the best on the list.

I will take that as "applied" ;-)  Thanks!

I now have to decide whether I should follow my heart (indent levels with
tabs, everything else with spaces), or just decide that the kernel
hopelessly chained to tabs-as-8-spaces-only land and pipe thinkpad-acpi
entirely through unexpand to get rid of a huge ammount of checkpatch.pl
nagging...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2007-11-17 20:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15  3:36 [GIT PATCH] thinkpad-acpi patches for 2.6.25 (batch 1) Henrique de Moraes Holschuh
2007-11-15  3:36 ` [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set Henrique de Moraes Holschuh
     [not found]   ` <1195097822-24738-2-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-11-15 18:14     ` Len Brown
2007-11-17 20:15       ` Henrique de Moraes Holschuh [this message]
     [not found]         ` <20071117201501.GG30919-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-11-19 21:20           ` Len Brown
     [not found] ` <1195097822-24738-1-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-11-15  3:36   ` [PATCH 02/15] ACPI: thinkpad-acpi: prepare for NVRAM polling support Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 03/15] ACPI: thinkpad-acpi: add CMOS NVRAM polling for hot keys (v6) Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 04/15] ACPI: thinkpad-acpi: let threads be frozen Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 05/15] ACPI: thinkpad-acpi: bump up version to 0.18 Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 06/15] ACPI: thinkpad-acpi: spring cleanup part 1 Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 07/15] ACPI: thinkpad-acpi: spring cleanup part 2 Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 11/15] ACPI: thinkpad-acpi: rename IBM in defines Henrique de Moraes Holschuh
2007-11-15  3:36   ` [PATCH 12/15] ACPI: thinkpad-acpi: some checkpatch.pl fluff Henrique de Moraes Holschuh
2007-11-15  3:37   ` [PATCH 13/15] ACPI: thinkpad-acpi: add suspend handler Henrique de Moraes Holschuh
2007-11-15  3:37   ` [PATCH 15/15] ACPI: thinkpad-acpi: wakeup on hotunplug reporting Henrique de Moraes Holschuh
2007-11-15  3:36 ` [PATCH 08/15] ACPI: thinkpad-acpi: spring cleanup part 3 Henrique de Moraes Holschuh
2007-11-15  3:36 ` [PATCH 09/15] ACPI: thinkpad-acpi: spring cleanup part 4 Henrique de Moraes Holschuh
2007-11-15  3:36 ` [PATCH 10/15] ACPI: thinkpad-acpi: module glue cleanups Henrique de Moraes Holschuh
2007-11-15  3:37 ` [PATCH 14/15] ACPI: thinkpad-acpi: cleanup hotkey_notify and HKEY log messages Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071117201501.GG30919@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox