From: Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set
Date: Mon, 19 Nov 2007 16:20:29 -0500 [thread overview]
Message-ID: <200711191620.29954.lenb@kernel.org> (raw)
In-Reply-To: <20071117201501.GG30919-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
> I now have to decide whether I should follow my heart (indent levels with
> tabs, everything else with spaces), or just decide that the kernel
> hopelessly chained to tabs-as-8-spaces-only land and pipe thinkpad-acpi
> entirely through unexpand to get rid of a huge ammount of checkpatch.pl
> nagging...
I don't take sides on whitespace issues, but instead refer all to Lindent.
So run the driver through scripts/Lindent and see what you get.
cheers,
-Len
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2007-11-19 21:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 3:36 [GIT PATCH] thinkpad-acpi patches for 2.6.25 (batch 1) Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set Henrique de Moraes Holschuh
[not found] ` <1195097822-24738-2-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-11-15 18:14 ` Len Brown
2007-11-17 20:15 ` Henrique de Moraes Holschuh
[not found] ` <20071117201501.GG30919-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2007-11-19 21:20 ` Len Brown [this message]
2007-11-15 3:36 ` [PATCH 08/15] ACPI: thinkpad-acpi: spring cleanup part 3 Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 09/15] ACPI: thinkpad-acpi: spring cleanup part 4 Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 10/15] ACPI: thinkpad-acpi: module glue cleanups Henrique de Moraes Holschuh
[not found] ` <1195097822-24738-1-git-send-email-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2007-11-15 3:36 ` [PATCH 02/15] ACPI: thinkpad-acpi: prepare for NVRAM polling support Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 03/15] ACPI: thinkpad-acpi: add CMOS NVRAM polling for hot keys (v6) Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 04/15] ACPI: thinkpad-acpi: let threads be frozen Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 05/15] ACPI: thinkpad-acpi: bump up version to 0.18 Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 06/15] ACPI: thinkpad-acpi: spring cleanup part 1 Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 07/15] ACPI: thinkpad-acpi: spring cleanup part 2 Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 11/15] ACPI: thinkpad-acpi: rename IBM in defines Henrique de Moraes Holschuh
2007-11-15 3:36 ` [PATCH 12/15] ACPI: thinkpad-acpi: some checkpatch.pl fluff Henrique de Moraes Holschuh
2007-11-15 3:37 ` [PATCH 13/15] ACPI: thinkpad-acpi: add suspend handler Henrique de Moraes Holschuh
2007-11-15 3:37 ` [PATCH 15/15] ACPI: thinkpad-acpi: wakeup on hotunplug reporting Henrique de Moraes Holschuh
2007-11-15 3:37 ` [PATCH 14/15] ACPI: thinkpad-acpi: cleanup hotkey_notify and HKEY log messages Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711191620.29954.lenb@kernel.org \
--to=lenb-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox