public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Starikovskiy <aystarik@gmail.com>
Cc: eike-kernel@sf-tec.de, lenb@kernel.org,
	linux-acpi@vger.kernel.org, astarikovskiy@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix segfault when printing battery status
Date: Mon, 26 Nov 2007 14:25:10 -0800	[thread overview]
Message-ID: <20071126142510.9f89ea0e.akpm@linux-foundation.org> (raw)
In-Reply-To: <47416EFF.3070402@gmail.com>

On Mon, 19 Nov 2007 14:09:51 +0300
Alexey Starikovskiy <aystarik@gmail.com> wrote:

> Rolf Eike Beer wrote:
> > Alexey Starikovskiy wrote:
> >   
> >> Rolf Eike Beer wrote:
> >>     
> >>> cat
> >>> /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_
> >>> supply/BAT1/status
> >>>
> >>> This leads to a stacktrace as acpi_battery_get_property() returns 0 for a
> >>> case where it does not set val->intval. These value is used as an array
> >>> index in
> >>> drivers/power/power_supply_sysfs.c::power_supply_show_property(). I had a
> >>> situation where the value was 4096 which caused a problem as the array
> >>> only has 5 entries.
> >>>
> >>> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> >>>       
> >> Rolf, thanks for remainding.
> >>     
> >
> > Huh? This one is unrelated to the problem I reported two weeks ago...
> >
> > Eike
> >   
> You are second to send the same patch, first one I already acked.
> But it seems that Len did not pick it up yet.
> Look for "ACPI: Always return valid 'status' from 
> acpi_battery_get_property()"
> if interested...
> 

This fix is in Len's tree and was in his 2.6.24-rc3 pull request to
Linus.

      reply	other threads:[~2007-11-26 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18 19:49 [PATCH] Fix segfault when printing battery status Rolf Eike Beer
2007-11-19  9:45 ` Alexey Starikovskiy
2007-11-19 10:29   ` Rolf Eike Beer
2007-11-19 11:09     ` Alexey Starikovskiy
2007-11-26 22:25       ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071126142510.9f89ea0e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=astarikovskiy@suse.de \
    --cc=aystarik@gmail.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox