From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org,
pm list <linux-pm@lists.linux-foundation.org>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 1/2] HWMON: coretemp, suspend fix
Date: Mon, 3 Dec 2007 18:01:50 +0100 [thread overview]
Message-ID: <200712031801.51513.rjw@sisk.pl> (raw)
In-Reply-To: <200712031755.44441.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
It's not permitted to unregister a device after devices have been suspended.
It causes deadlocks to appear on systems with coretemp hwmon loaded. To avoid
this, we can make coretemp_cpu_callback() do nothing if the _FROZEN bit is set
in action.
Also, in other cases it's generally too late to unregister the coretemp device
if the CPU is already dead, so it should be unregistered on CPU_DOWN_PREPARE.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Mark M. Hoffman <mhoffman@lightlink.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
drivers/hwmon/coretemp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/hwmon/coretemp.c
===================================================================
--- linux-2.6.orig/drivers/hwmon/coretemp.c
+++ linux-2.6/drivers/hwmon/coretemp.c
@@ -337,11 +337,10 @@ static int coretemp_cpu_callback(struct
switch (action) {
case CPU_ONLINE:
- case CPU_ONLINE_FROZEN:
+ case CPU_DOWN_FAILED:
coretemp_device_add(cpu);
break;
- case CPU_DEAD:
- case CPU_DEAD_FROZEN:
+ case CPU_DOWN_PREPARE:
coretemp_device_remove(cpu);
break;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-03 16:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 19:48 ACPI patches for rc3 - part 2 Len Brown
[not found] ` <357dc4c3f13cb5c1e3b40a09cbe6ff1b0df2c7c3.1196624815.git.len.brown@intel.com>
2007-12-02 19:48 ` [PATCH 1/2] ACPI: Delete the IRQ operation in throttling controll via PTC Len Brown
[not found] ` <152c300d007c70c4a1847dad39ecdaba22e7d457.1196624815.git.len.brown@intel.com>
2007-12-02 19:48 ` [PATCH 2/2] ACPICA: fix acpi-cpufreq boot crash due to _PSD return-by-reference Len Brown
2007-12-03 16:55 ` ACPI patches for rc3 - part 2 Rafael J. Wysocki
2007-12-03 17:01 ` Rafael J. Wysocki [this message]
2007-12-04 6:29 ` [PATCH 1/2] HWMON: coretemp, suspend fix Len Brown
2007-12-04 19:59 ` Rafael J. Wysocki
2007-12-03 17:03 ` [PATCH 2/2] Freezer: Fix JFFS2 garbage collector freezing issue Rafael J. Wysocki
2007-12-03 23:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712031801.51513.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox