suspend to RAM failure on t61p

suspend to RAM failure on t61p

[Andrew Morton]

2.6.24-rc4 on a Lenovo t61p, using FC8 config.

echo mem > /sys/power/state while running X.

It appears to suspend OK but then it instantly resumes and runs
OK except the display is blank.

A copy of /proc/acpi/dsdt is at http://userweb.kernel.org/~akpm/dsdt.t61p
config: http://userweb.kernel.org/~akpm/config-t61p.txt
dmesg: http://userweb.kernel.org/~akpm/dmesg-t61p.txt

Re: suspend to RAM failure on t61p

[Tomas Carnecky]

Andrew Morton wrote:
> 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> 
> echo mem > /sys/power/state while running X.
> 
> It appears to suspend OK but then it instantly resumes and runs
> OK except the display is blank.

http://bugzilla.kernel.org/show_bug.cgi?id=9258

I have a X61 tablet, and the screen is blank after resume, too, but
pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
video driver. I'm not sure though.

tom

Re: suspend to RAM failure on t61p

[Rafael J. Wysocki]

On Sunday, 9 of December 2007, Tomas Carnecky wrote:
> Andrew Morton wrote:
> > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > 
> > echo mem > /sys/power/state while running X.
> > 
> > It appears to suspend OK but then it instantly resumes and runs
> > OK except the display is blank.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=9258

Yeah.

If you have a box on which the issue is visible, please add a comment in there.

> I have a X61 tablet, and the screen is blank after resume, too, but
> pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> video driver. I'm not sure though.

s2ram has a chance to work around this.

Greetings,
Rafael

Re: suspend to RAM failure on t61p

[Volker Braun]

On Sun, 09 Dec 2007 01:19:28 -0800, Andrew Morton wrote:
> 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> echo mem > /sys/power/state while running X.

On Fedora you should use System->Suspend or /usr/bin/pm-suspend from pm-
utils. See also /usr/share/hal/fdi/information/10freedesktop/20-video-
quirk-pm-lenovo.fdi, maybe you can fix yours if it still doesn't work.

Volker

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:

> Andrew Morton wrote:
> > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > 
> > echo mem > /sys/power/state while running X.
> > 
> > It appears to suspend OK but then it instantly resumes and runs
> > OK except the display is blank.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=9258
> 
> I have a X61 tablet, and the screen is blank after resume, too, but
> pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> video driver. I'm not sure though.
> 

This machine doesn't bring the display back after resume-from-RAM under
2.6.23 either.

The post-2.6.23 regresison here is that the suspend itself fails.  Under
2.6.23 the machine suspends and requires a keystrike to start resuming. 
Under 2.6.24-rc4 it just instantly resumes all by itself.

And I'm having real problems working out why 2.6.23 and 2.6.24-rc4 work
OK(ish) but anything in between won't boot: can't open /dev/root. 
Everything has scrolled off, no serial, no netconsole..  

Re: suspend to RAM failure on t61p

[Rafael J. Wysocki]

On Monday, 10 of December 2007, Andrew Morton wrote:
> On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:
> 
> > Andrew Morton wrote:
> > > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > > 
> > > echo mem > /sys/power/state while running X.
> > > 
> > > It appears to suspend OK but then it instantly resumes and runs
> > > OK except the display is blank.
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=9258
> > 
> > I have a X61 tablet, and the screen is blank after resume, too, but
> > pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> > video driver. I'm not sure though.
> > 
> 
> This machine doesn't bring the display back after resume-from-RAM under
> 2.6.23 either.
> 
> The post-2.6.23 regresison here is that the suspend itself fails.  Under
> 2.6.23 the machine suspends and requires a keystrike to start resuming. 
> Under 2.6.24-rc4 it just instantly resumes all by itself.

Please see if the appended patch helps (it will probably break the RTC wakeup
again, but well ...).


---
 kernel/power/disk.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Index: linux-2.6/kernel/power/disk.c
===================================================================
--- linux-2.6.orig/kernel/power/disk.c
+++ linux-2.6/kernel/power/disk.c
@@ -378,9 +378,12 @@ int hibernation_platform_enter(void)
 		return error;
 
 	suspend_console();
-	error = device_suspend(PMSG_SUSPEND);
-	if (error)
-		goto Resume_console;
+	/*
+	 * FIXME: device_suspend(PMSG_SUSPEND) should be called here, but
+	 * some EHCI controllers make boxes reboot instead of going into the
+	 * S4 sleep state in that case.
+	 */
+	device_shutdown();
 
 	error = hibernation_ops->prepare();
 	if (error)

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Mon, 10 Dec 2007 02:04:13 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Monday, 10 of December 2007, Andrew Morton wrote:
> > On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:
> > 
> > > Andrew Morton wrote:
> > > > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > > > 
> > > > echo mem > /sys/power/state while running X.
> > > > 
> > > > It appears to suspend OK but then it instantly resumes and runs
> > > > OK except the display is blank.
> > > 
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9258
> > > 
> > > I have a X61 tablet, and the screen is blank after resume, too, but
> > > pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> > > video driver. I'm not sure though.
> > > 
> > 
> > This machine doesn't bring the display back after resume-from-RAM under
> > 2.6.23 either.
> > 
> > The post-2.6.23 regresison here is that the suspend itself fails.  Under
> > 2.6.23 the machine suspends and requires a keystrike to start resuming. 
> > Under 2.6.24-rc4 it just instantly resumes all by itself.
> 
> Please see if the appended patch helps (it will probably break the RTC wakeup
> again, but well ...).
> 
> 
> ---
>  kernel/power/disk.c |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> Index: linux-2.6/kernel/power/disk.c
> ===================================================================
> --- linux-2.6.orig/kernel/power/disk.c
> +++ linux-2.6/kernel/power/disk.c
> @@ -378,9 +378,12 @@ int hibernation_platform_enter(void)
>  		return error;
>  
>  	suspend_console();
> -	error = device_suspend(PMSG_SUSPEND);
> -	if (error)
> -		goto Resume_console;
> +	/*
> +	 * FIXME: device_suspend(PMSG_SUSPEND) should be called here, but
> +	 * some EHCI controllers make boxes reboot instead of going into the
> +	 * S4 sleep state in that case.
> +	 */
> +	device_shutdown();
>  
>  	error = hibernation_ops->prepare();
>  	if (error)

Nope, the machine still instantly resumes after suspend-to-RAM.

Sigh.  I guess I need to git-bisect my cant-find-root-disk problem and then
once that is fixed I can bisect this suspend-to-RAM-resumes-itself
regression and the resume-from-disk-causes-reboot regression.

Re: suspend to RAM failure on t61p

[Rafael J. Wysocki]

On Monday, 10 of December 2007, Andrew Morton wrote:
> On Mon, 10 Dec 2007 02:04:13 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > On Monday, 10 of December 2007, Andrew Morton wrote:
> > > On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:
> > > 
> > > > Andrew Morton wrote:
> > > > > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > > > > 
> > > > > echo mem > /sys/power/state while running X.
> > > > > 
> > > > > It appears to suspend OK but then it instantly resumes and runs
> > > > > OK except the display is blank.
> > > > 
> > > > http://bugzilla.kernel.org/show_bug.cgi?id=9258
> > > > 
> > > > I have a X61 tablet, and the screen is blank after resume, too, but
> > > > pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> > > > video driver. I'm not sure though.
> > > > 
> > > 
> > > This machine doesn't bring the display back after resume-from-RAM under
> > > 2.6.23 either.
> > > 
> > > The post-2.6.23 regresison here is that the suspend itself fails.  Under
> > > 2.6.23 the machine suspends and requires a keystrike to start resuming. 
> > > Under 2.6.24-rc4 it just instantly resumes all by itself.
> > 
> > Please see if the appended patch helps (it will probably break the RTC wakeup
> > again, but well ...).
> > 
> > 
> > ---
> >  kernel/power/disk.c |    9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > Index: linux-2.6/kernel/power/disk.c
> > ===================================================================
> > --- linux-2.6.orig/kernel/power/disk.c
> > +++ linux-2.6/kernel/power/disk.c
> > @@ -378,9 +378,12 @@ int hibernation_platform_enter(void)
> >  		return error;
> >  
> >  	suspend_console();
> > -	error = device_suspend(PMSG_SUSPEND);
> > -	if (error)
> > -		goto Resume_console;
> > +	/*
> > +	 * FIXME: device_suspend(PMSG_SUSPEND) should be called here, but
> > +	 * some EHCI controllers make boxes reboot instead of going into the
> > +	 * S4 sleep state in that case.
> > +	 */
> > +	device_shutdown();
> >  
> >  	error = hibernation_ops->prepare();
> >  	if (error)
> 
> Nope, the machine still instantly resumes after suspend-to-RAM.
> 
> Sigh.  I guess I need to git-bisect my cant-find-root-disk problem and then
> once that is fixed I can bisect this suspend-to-RAM-resumes-itself
> regression and the resume-from-disk-causes-reboot regression.

Well, please try to revert the entire commit 9cd9a0058dd35268b24fa16795a92c800f4086d4
"Hibernation: Enter platform hibernation state in a consistent way" for the last one.

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Mon, 10 Dec 2007 12:06:14 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Monday, 10 of December 2007, Andrew Morton wrote:
> > On Mon, 10 Dec 2007 02:04:13 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > 
> > > On Monday, 10 of December 2007, Andrew Morton wrote:
> > > > On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:
> > > > 
> > > > > Andrew Morton wrote:
> > > > > > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > > > > > 
> > > > > > echo mem > /sys/power/state while running X.
> > > > > > 
> > > > > > It appears to suspend OK but then it instantly resumes and runs
> > > > > > OK except the display is blank.
> > > > > 
> > > > > http://bugzilla.kernel.org/show_bug.cgi?id=9258
> > > > > 
> > > > > I have a X61 tablet, and the screen is blank after resume, too, but
> > > > > pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> > > > > video driver. I'm not sure though.
> > > > > 
> > > > 
> > > > This machine doesn't bring the display back after resume-from-RAM under
> > > > 2.6.23 either.
> > > > 
> > > > The post-2.6.23 regresison here is that the suspend itself fails.  Under
> > > > 2.6.23 the machine suspends and requires a keystrike to start resuming. 
> > > > Under 2.6.24-rc4 it just instantly resumes all by itself.
> > > 
> > > Please see if the appended patch helps (it will probably break the RTC wakeup
> > > again, but well ...).
> > > 
> > > 
> > > ---
> > >  kernel/power/disk.c |    9 ++++++---
> > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > > 
> > > Index: linux-2.6/kernel/power/disk.c
> > > ===================================================================
> > > --- linux-2.6.orig/kernel/power/disk.c
> > > +++ linux-2.6/kernel/power/disk.c
> > > @@ -378,9 +378,12 @@ int hibernation_platform_enter(void)
> > >  		return error;
> > >  
> > >  	suspend_console();
> > > -	error = device_suspend(PMSG_SUSPEND);
> > > -	if (error)
> > > -		goto Resume_console;
> > > +	/*
> > > +	 * FIXME: device_suspend(PMSG_SUSPEND) should be called here, but
> > > +	 * some EHCI controllers make boxes reboot instead of going into the
> > > +	 * S4 sleep state in that case.
> > > +	 */
> > > +	device_shutdown();
> > >  
> > >  	error = hibernation_ops->prepare();
> > >  	if (error)
> > 
> > Nope, the machine still instantly resumes after suspend-to-RAM.
> > 
> > Sigh.  I guess I need to git-bisect my cant-find-root-disk problem and then
> > once that is fixed I can bisect this suspend-to-RAM-resumes-itself
> > regression and the resume-from-disk-causes-reboot regression.
> 
> Well, please try to revert the entire commit 9cd9a0058dd35268b24fa16795a92c800f4086d4
> "Hibernation: Enter platform hibernation state in a consistent way" for the last one.

Yes, reverting 9cd9a0058dd35268b24fa16795a92c800f4086d4 fixes the
suspend-to-RAM problem: it now stays suspended.

However it doens't resume on a keystroke like 2.6.23 does: I have to tap the
power switch to make it resume.


However reverting 9cd9a0058dd35268b24fa16795a92c800f4086d4 does not fix the
machine-reboots-after-resume-from-disk regression.

It gets to here:

Attempting manual resume
swsusp: Marking nosave pages: 000000000009d000 - 0000000000100000
swsusp: Basic memory bitmaps created
Freezing user space processes ... (elapsed 0.00 seconds) done.
Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
Loading image data pages (52207 pages) ... done
Read 208828 kbytes in 5.40 seconds (38.67 MB/s)
Suspending console(s)

then everything stops for five seconds then wham.

This bug is present in 2.6.24-rc1 but I'm basically unable to bisect it
because every bisection point (tried about four so far) hits fatal runtime
errors: cant-find-/dev/root, an oops in ipv6, an oops in netfilter, etc.

This is just a basic boot-it-on-fc8 test with RH's config and nothing
works.  The quality of code which people have been checking into the tree
is just appalling and here we see the costs of that.

I think I'll see if it's present in the last 2.6.23 -mm lineup: I know I
can bisect that.  Probably it won't be, given the way in which people like
to jam vast amounts of new code into the merge window.

Sigh.

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Mon, 10 Dec 2007 22:21:56 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> However reverting 9cd9a0058dd35268b24fa16795a92c800f4086d4 does not fix the
> machine-reboots-after-resume-from-disk regression.
> 
> It gets to here:
> 
> Attempting manual resume
> swsusp: Marking nosave pages: 000000000009d000 - 0000000000100000
> swsusp: Basic memory bitmaps created
> Freezing user space processes ... (elapsed 0.00 seconds) done.
> Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
> Loading image data pages (52207 pages) ... done
> Read 208828 kbytes in 5.40 seconds (38.67 MB/s)
> Suspending console(s)
> 
> then everything stops for five seconds then wham.
> 
> This bug is present in 2.6.24-rc1 but I'm basically unable to bisect it
> because every bisection point (tried about four so far) hits fatal runtime
> errors: cant-find-/dev/root, an oops in ipv6, an oops in netfilter, etc.
> 
> This is just a basic boot-it-on-fc8 test with RH's config and nothing
> works.  The quality of code which people have been checking into the tree
> is just appalling and here we see the costs of that.
> 
> I think I'll see if it's present in the last 2.6.23 -mm lineup: I know I
> can bisect that.  Probably it won't be, given the way in which people like
> to jam vast amounts of new code into the merge window.
> 

Under 2.6.23-mm1 on the t61p,

	echo disk >/sys/power/state

makes the screen go black then nothing at all happens for ten seconds and
then the display comes back and it says:

t61p:/home/akpm# echo disk >/sys/power/state
echo: write error: device or resource busy

So I have to bisect that first.

This really sucks.

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Mon, 10 Dec 2007 22:58:58 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> On Mon, 10 Dec 2007 22:21:56 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > However reverting 9cd9a0058dd35268b24fa16795a92c800f4086d4 does not fix the
> > machine-reboots-after-resume-from-disk regression.
> > 
> > It gets to here:
> > 
> > Attempting manual resume
> > swsusp: Marking nosave pages: 000000000009d000 - 0000000000100000
> > swsusp: Basic memory bitmaps created
> > Freezing user space processes ... (elapsed 0.00 seconds) done.
> > Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
> > Loading image data pages (52207 pages) ... done
> > Read 208828 kbytes in 5.40 seconds (38.67 MB/s)
> > Suspending console(s)
> > 
> > then everything stops for five seconds then wham.
> > 
> > This bug is present in 2.6.24-rc1 but I'm basically unable to bisect it
> > because every bisection point (tried about four so far) hits fatal runtime
> > errors: cant-find-/dev/root, an oops in ipv6, an oops in netfilter, etc.
> > 
> > This is just a basic boot-it-on-fc8 test with RH's config and nothing
> > works.  The quality of code which people have been checking into the tree
> > is just appalling and here we see the costs of that.
> > 
> > I think I'll see if it's present in the last 2.6.23 -mm lineup: I know I
> > can bisect that.  Probably it won't be, given the way in which people like
> > to jam vast amounts of new code into the merge window.
> > 
> 
> Under 2.6.23-mm1 on the t61p,
> 
> 	echo disk >/sys/power/state
> 
> makes the screen go black then nothing at all happens for ten seconds and
> then the display comes back and it says:
> 
> t61p:/home/akpm# echo disk >/sys/power/state
> echo: write error: device or resource busy
> 
> So I have to bisect that first.
> 

This was caused by freezer-use-wait-queue-instead-of-busy-looping.patch
which we blessedly dropped.

After dropped that patch from 2.6.23-mm1, bisection shows that
hibernation-use-temporary-page-tables-for-kernel-text-mapping-on-x86_64.patch
is causing the t61p's reboot-after-resuming-from-disk regression. 
Reverting that patch from current Linus mainline fixes this regression.

Now let me see what caused the keystrokes-no-longer-trigger-resume-from-RAM
regression.

Re: suspend to RAM failure on t61p

[Andrew Morton]

On Tue, 11 Dec 2007 01:57:51 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:

> Now let me see what caused the keystrokes-no-longer-trigger-resume-from-RAM
> regression.

OK, I must have dreamed this - 2.6.23 requires a power-button tap to
come back from suspend-to-RAM as well.

Re: suspend to RAM failure on t61p

[Rafael J. Wysocki]

On Tuesday, 11 of December 2007, Andrew Morton wrote:
> On Mon, 10 Dec 2007 12:06:14 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > On Monday, 10 of December 2007, Andrew Morton wrote:
> > > On Mon, 10 Dec 2007 02:04:13 +0100 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > > 
> > > > On Monday, 10 of December 2007, Andrew Morton wrote:
> > > > > On Sun, 09 Dec 2007 13:40:07 +0100 Tomas Carnecky <tom@dbservice.com> wrote:
> > > > > 
> > > > > > Andrew Morton wrote:
> > > > > > > 2.6.24-rc4 on a Lenovo t61p, using FC8 config.
> > > > > > > 
> > > > > > > echo mem > /sys/power/state while running X.
> > > > > > > 
> > > > > > > It appears to suspend OK but then it instantly resumes and runs
> > > > > > > OK except the display is blank.
> > > > > > 
> > > > > > http://bugzilla.kernel.org/show_bug.cgi?id=9258
> > > > > > 
> > > > > > I have a X61 tablet, and the screen is blank after resume, too, but
> > > > > > pressing ctrl+alt+F1/F7 usually fixes it. It seems a problem with the X
> > > > > > video driver. I'm not sure though.
> > > > > > 
> > > > > 
> > > > > This machine doesn't bring the display back after resume-from-RAM under
> > > > > 2.6.23 either.
> > > > > 
> > > > > The post-2.6.23 regresison here is that the suspend itself fails.  Under
> > > > > 2.6.23 the machine suspends and requires a keystrike to start resuming. 
> > > > > Under 2.6.24-rc4 it just instantly resumes all by itself.
> > > > 
> > > > Please see if the appended patch helps (it will probably break the RTC wakeup
> > > > again, but well ...).
> > > > 
> > > > 
> > > > ---
> > > >  kernel/power/disk.c |    9 ++++++---
> > > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > > > 
> > > > Index: linux-2.6/kernel/power/disk.c
> > > > ===================================================================
> > > > --- linux-2.6.orig/kernel/power/disk.c
> > > > +++ linux-2.6/kernel/power/disk.c
> > > > @@ -378,9 +378,12 @@ int hibernation_platform_enter(void)
> > > >  		return error;
> > > >  
> > > >  	suspend_console();
> > > > -	error = device_suspend(PMSG_SUSPEND);
> > > > -	if (error)
> > > > -		goto Resume_console;
> > > > +	/*
> > > > +	 * FIXME: device_suspend(PMSG_SUSPEND) should be called here, but
> > > > +	 * some EHCI controllers make boxes reboot instead of going into the
> > > > +	 * S4 sleep state in that case.
> > > > +	 */
> > > > +	device_shutdown();
> > > >  
> > > >  	error = hibernation_ops->prepare();
> > > >  	if (error)
> > > 
> > > Nope, the machine still instantly resumes after suspend-to-RAM.
> > > 
> > > Sigh.  I guess I need to git-bisect my cant-find-root-disk problem and then
> > > once that is fixed I can bisect this suspend-to-RAM-resumes-itself
> > > regression and the resume-from-disk-causes-reboot regression.
> > 
> > Well, please try to revert the entire commit 9cd9a0058dd35268b24fa16795a92c800f4086d4
> > "Hibernation: Enter platform hibernation state in a consistent way" for the last one.
> 
> Yes, reverting 9cd9a0058dd35268b24fa16795a92c800f4086d4 fixes the
> suspend-to-RAM problem: it now stays suspended.

Well, this patch doesn't touch the suspend-to-RAM code path, it only touches
the last phase of hibernation.  I'm quite sure it can't affect the suspend to
RAM.