From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Joshua Wise <joshua@joshuawise.com>
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 3/5] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
Date: Thu, 13 Dec 2007 16:41:46 +0000 [thread overview]
Message-ID: <200712131641.46641.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.63.0712120224340.19698@dashnine.joshuawise.com>
On Wednesday 12 December 2007 07:26:24 Joshua Wise wrote:
> On Wed, 12 Dec 2007, Carlos Corbacho wrote:
> > + case TC1100_INSTANCE_BLUETOOTH:
> > + *out = (tmp == 1) ? 1 : 0;
> > + return 0;
>
> This doesn't actually control Bluetooth. This controls whether the jog
> dial is in normal mode or brightness select mode.
Is this a mistake then from the original tc1100-wmi (the 'bluetooth' file
never controlled bluetooth, it always controlled the jog dial), or a mistake
in my patch (it should control bluetooth, but is changing the jog dial
instead)?
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2007-12-13 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 2:01 [PATCH 0/5] WMI Carlos Corbacho
2007-12-12 2:07 ` [PATCH 1/5] ACPI: WMI: Add ACPI-WMI mapping driver Carlos Corbacho
2007-12-12 2:08 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2007-12-12 2:08 ` [PATCH 3/5] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets Carlos Corbacho
2007-12-12 7:26 ` Joshua Wise
2007-12-13 16:41 ` Carlos Corbacho [this message]
2007-12-13 21:06 ` Joshua Wise
2007-12-12 2:09 ` [PATCH 4/5] ACPI: WMI: Add sysfs userspace interface Carlos Corbacho
2007-12-12 2:09 ` [PATCH 5/5] ACPI: WMI: Limit size of device string to 19 characters Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712131641.46641.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=joshua@joshuawise.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox