public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-acpi@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: brightness control on thinkpad t61p
Date: Mon, 24 Dec 2007 15:08:37 -0200	[thread overview]
Message-ID: <20071224170837.GC7907@khazad-dum.debian.net> (raw)
In-Reply-To: <20071223000057.739d5891.akpm@linux-foundation.org>

On Sun, 23 Dec 2007, Andrew Morton wrote:
> When I fire up the latest Linus tree on my thinkpad t61p I get:
> 
> thinkpad_acpi: ThinkPad ACPI Extras v0.17
> thinkpad_acpi: http://ibm-acpi.sf.net/
> thinkpad_acpi: ThinkPad BIOS 7LET44WW (1.14 ), EC 7KHT22WW-1.06
> thinkpad_acpi: Lenovo ThinkPad T61p
> thinkpad_acpi: radio switch found; radios are enabled
> ACPI: Lid Switch [LID]
> input: Sleep Button (CM) as /class/input/input6
> ACPI: Sleep Button (CM) [SLPB]
> thinkpad_acpi: standard ACPI backlight interface available, not loading native one...
> 
> and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so
> my `brightness' script no longer works.  That, my friends, is a regression.

For thinkpad-acpi at least, it is not a regression. 2.6.23/0.16 did NOT
support your thinkpad (it will pretend to work, but it won't work 100% right
as it only supports 8 levels of backlight control).  2.6.24-rc4/0.17 added
support for it (16-level brightness), but also added the automatic detection
of ACPI generic video support.

You can ask thinkpad-acpi for the backlight interface using the
"brightness_enable=1" parameter, if you'd rather use it instead of the
generic ACPI video driver.  I don't know if you can ask video to not enable
backlight control, though.

> So I go hunting around and find
> 
> 	/sys/class/backlight/acpi_video0/
> and
> 	/sys/class/backlight/acpi_video1/
> 
> Why are there two of them?

Two nodes in the ACPI tree (AGP and PCI), and the ACPI drivers don't
differentiate a deactivated node from a working node yet.  There are some
tentative patches flying around to fix it, AFAIK.

> Both of these have a `brightness' entry which has contents of 100.  When I set
> that to 10, the screen's brightness is not reduced.

One of them should work.  Maybe X.org is doing something?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  parent reply	other threads:[~2007-12-24 17:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-23  8:00 brightness control on thinkpad t61p Andrew Morton
2007-12-23 12:16 ` Rafael J. Wysocki
2007-12-24  7:34 ` Matthew Garrett
2007-12-24 17:14   ` Henrique de Moraes Holschuh
2007-12-26 22:10   ` Andrew Morton
2007-12-26 22:23     ` Matthew Garrett
2007-12-27 12:33       ` Henrique de Moraes Holschuh
2008-01-07  1:36         ` Henrique de Moraes Holschuh
2008-01-07 19:48           ` Matthew Garrett
2008-01-08  0:32             ` Henrique de Moraes Holschuh
2008-01-08  0:45               ` Matthew Garrett
2008-01-08 12:06                 ` Henrique de Moraes Holschuh
2008-01-08 12:18                   ` Matthew Garrett
2008-01-08 12:48                     ` Henrique de Moraes Holschuh
2008-01-08 15:17                       ` Matthew Garrett
2008-01-08 15:45                       ` Richard Purdie
2008-01-08 15:54                         ` Matthew Garrett
2008-01-08 16:29                           ` Richard Purdie
2008-01-08 16:49                             ` Henrique de Moraes Holschuh
2008-01-08 16:56                               ` Richard Purdie
2008-01-08 17:36                                 ` Henrique de Moraes Holschuh
2007-12-27 12:31     ` Henrique de Moraes Holschuh
2007-12-24 17:08 ` Henrique de Moraes Holschuh [this message]
2007-12-26 22:10   ` Andrew Morton
2007-12-27 13:15     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071224170837.GC7907@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=akpm@linux-foundation.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox