From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: brightness control on thinkpad t61p
Date: Mon, 24 Dec 2007 15:14:05 -0200 [thread overview]
Message-ID: <20071224171405.GD7907@khazad-dum.debian.net> (raw)
In-Reply-To: <20071224073406.GA1018@srcf.ucam.org>
On Mon, 24 Dec 2007, Matthew Garrett wrote:
> On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote:
>
> > and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so
> > my `brightness' script no longer works. That, my friends, is a regression.
>
> The thinkpad_acpi brightness interface simply doesn't work correctly on
> recent Thinkpads. The ACPI interface does, but the currently exported ui
Yes, it does since 2.6.24-rc4. And since MUCH earlier in the out-of-tree
develompent versions.
What usually causes weird breakage is to have more than one of (Ubuntu
hackage in HAL calling back into thinkpad-acpi, X.org, ACPI video) trying to
respond to brightness up/down. And you *do* *have* to use the latest Lenovo
BIOSes, too.
Also, apparently now X.org knows how to tell the BIOS to not react to
backlight changes, so you have to configure it properly (I don't know much
about it), too.
Matthew, btw, Dmitri approved the _NOTIFY keycodes, which need to be part of
the solution re. backlight control in thinkpads. Are you intending to push
a patch implementing them? As I said before, I am okay with that solution,
as long as Dmitri accepted it, and I will use _NOTIFY keycodes in
thinkpad-acpi when they become available.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2007-12-24 17:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 8:00 brightness control on thinkpad t61p Andrew Morton
2007-12-23 12:16 ` Rafael J. Wysocki
2007-12-24 7:34 ` Matthew Garrett
2007-12-24 17:14 ` Henrique de Moraes Holschuh [this message]
2007-12-26 22:10 ` Andrew Morton
2007-12-26 22:23 ` Matthew Garrett
2007-12-27 12:33 ` Henrique de Moraes Holschuh
2008-01-07 1:36 ` Henrique de Moraes Holschuh
2008-01-07 19:48 ` Matthew Garrett
2008-01-08 0:32 ` Henrique de Moraes Holschuh
2008-01-08 0:45 ` Matthew Garrett
2008-01-08 12:06 ` Henrique de Moraes Holschuh
2008-01-08 12:18 ` Matthew Garrett
2008-01-08 12:48 ` Henrique de Moraes Holschuh
2008-01-08 15:17 ` Matthew Garrett
2008-01-08 15:45 ` Richard Purdie
2008-01-08 15:54 ` Matthew Garrett
2008-01-08 16:29 ` Richard Purdie
2008-01-08 16:49 ` Henrique de Moraes Holschuh
2008-01-08 16:56 ` Richard Purdie
2008-01-08 17:36 ` Henrique de Moraes Holschuh
2007-12-27 12:31 ` Henrique de Moraes Holschuh
2007-12-24 17:08 ` Henrique de Moraes Holschuh
2007-12-26 22:10 ` Andrew Morton
2007-12-27 13:15 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071224171405.GD7907@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox