From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Alexey Starikovskiy <aystarik@gmail.com>
Subject: Re: [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver
Date: Thu, 27 Dec 2007 02:21:40 +0000 [thread overview]
Message-ID: <20071227022140.GA2143@srcf.ucam.org> (raw)
In-Reply-To: <200712270109.40121.carlos@strangeworlds.co.uk>
On Thu, Dec 27, 2007 at 01:09:39AM +0000, Carlos Corbacho wrote:
> On Wednesday 26 December 2007 21:17:18 Matthew Garrett wrote:
> > + if (!wmi_external_handler)
> > + return AE_ALREADY_ACQUIRED;
>
> I'm not sure (mostly because I don't like dealing with typedefs around
> pointers, and this bit is also untested).
At the moment, it's impossible to register a handler - I always get
AE_ALREADY_ACQUIRED. Getting rid of the ! makes things work like I
expected.
> > I'm also a bit
> > unhappy about only being able to register one notification handler, if
> > we consider the case where vendors add and remove WMI interfaces over
> > time - it might make sense to have individual small drivers rather than
> > one big one, which would mean a notification handler per GUID. Any
> > thoughts?
>
> Yes, a notification handler per GUID does make sense, so I'll add that to WMI.
Excellent, thanks!
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-12-27 2:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 23:51 [PATCH 0/5] WMI Carlos Corbacho
2007-12-18 23:51 ` [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver Carlos Corbacho
2007-12-26 21:17 ` Matthew Garrett
2007-12-27 1:09 ` Carlos Corbacho
2007-12-27 2:21 ` Matthew Garrett [this message]
2007-12-18 23:51 ` [PATCH 2/4] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2007-12-19 1:58 ` Carlos Corbacho
2007-12-19 7:45 ` Matthew Garrett
2007-12-18 23:51 ` [PATCH 3/4] [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets Carlos Corbacho
2007-12-18 23:52 ` [PATCH 4/4] [RFC] ACPI: WMI: Add sysfs userspace interface Carlos Corbacho
2007-12-26 19:38 ` Matthew Garrett
2007-12-27 0:54 ` Carlos Corbacho
2007-12-27 1:05 ` Carlos Corbacho
2007-12-26 22:48 ` [PATCH, RFC] HP WMI hotkey driver Matthew Garrett
2008-01-03 16:58 ` Dmitry Torokhov
2008-01-14 17:41 ` [PATCH, RFC] HP WMI hotkey driver, RFKill query? Matthew Garrett
2008-01-14 18:27 ` Carlos Corbacho
2008-01-14 22:25 ` Carlos Corbacho
2008-01-15 20:54 ` Dmitry Torokhov
2008-01-16 1:38 ` Carlos Corbacho
2008-01-16 1:49 ` Matthew Garrett
2008-02-07 3:54 ` Len Brown
2008-02-08 15:26 ` Carlos Corbacho
-- strict thread matches above, loose matches on Subject: below --
2007-12-08 1:58 [PATCH 0/4] WMI & acer_wmi Carlos Corbacho
2007-12-08 2:00 ` [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver Carlos Corbacho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071227022140.GA2143@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=aystarik@gmail.com \
--cc=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).