Re: [PATCH] PM: Acquire device locks on suspend

Alan Stern
2008-01-06T22:31:32Z

On Sun, 6 Jan 2008, Rafael J. Wysocki wrote:

> Still, our present approach doesn't seem to be correct overall. For example,
> I think we should prevent a suspend from happening while a device is being
> removed.

We could, however I don't think it's dangerous to allow it. The two
problems to avoid are (1) messing up the PM device list pointers, and
(2) calling a driver's suspend/resume methods while its remove method
is running. (1) is handled by the pm_list_mutex and (2) is handled by
locking dev->sem.

Alan Stern