From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: LenBrown <lenb@kernel.org>
Cc: Linux-acpi@vger.kernel.org
Subject: [PATCH 2/2] ACPI: EC: Some hardware requires burst mode to operate properly
Date: Fri, 11 Jan 2008 02:42:57 +0300 [thread overview]
Message-ID: <20080110234257.26720.77000.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080110234250.26720.16527.stgit@localhost.localdomain>
Burst mode temporary (50 ms) locks EC to do only transactions with
driver, without it some hardware returns abstract garbage.
Reference: http://bugzilla.kernel.org/show_bug.cgi?id=9341
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---
drivers/acpi/ec.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 1de0905..98a5388 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -575,6 +575,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
if (bits != 8 && acpi_strict)
return AE_BAD_PARAMETER;
+ acpi_ec_burst_enable(ec);
+
if (function == ACPI_READ) {
result = acpi_ec_read(ec, address, &temp);
*value = temp;
@@ -594,6 +596,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
}
}
+ acpi_ec_burst_disable(ec);
+
switch (result) {
case -EINVAL:
return AE_BAD_PARAMETER;
next prev parent reply other threads:[~2008-01-10 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 23:42 [PATCH 1/2] ACPI: EC: Do the byte access with a fast path Alexey Starikovskiy
2008-01-10 23:42 ` Alexey Starikovskiy [this message]
2008-01-11 1:51 ` [PATCH 2/2] ACPI: EC: Some hardware requires burst mode to operate properly Len Brown
2008-01-11 1:50 ` [PATCH 1/2] ACPI: EC: Do the byte access with a fast path Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110234257.26720.77000.stgit@localhost.localdomain \
--to=astarikovskiy@suse.de \
--cc=Linux-acpi@vger.kernel.org \
--cc=lenb@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox