Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

Andrew Morton
2008-01-12T03:21:34Z

On Fri, 11 Jan 2008 22:11:52 -0500 (EST) Alan Stern <stern@rowland.harvard.edu> wrote:

> On Fri, 11 Jan 2008, Greg KH wrote:
>
> > On Fri, Jan 11, 2008 at 04:49:04PM -0800, Andrew Morton wrote:
>
> > > err, no. pm-introduce-destroy_suspended_device.patch demolishes
> > > pm-acquire-device-locks-on-suspend-rev-3.patch
> > >
> > > Confused, giving up.
> >
> > I'm confused too, I have no idea what the proper order of things should
> > be either. Anyone want to give me a hint?
>
> Sorry for the confusion. The correct patch to apply is
> pm-acquire-device-locks-on-suspend-rev-3 (plus the attending
> style-fixups). It encompasses those earlier patches.
>
> The real problem is that our current email workflow patterns don't
> provide a standardized way for maintainers to tell when a new patch
> submission is meant to override or replace an earlier submission (or
> even a set of earlier submissions). Does anybody have some suggestions
> for a good way to do this?
>

Don't formally send it until it's ready. Seriously. You can always resend
it if it didn't get applied anywhere.

Once a patch reaches a sufficient level of maturity for it to be ready to
be merged into a subsystem tree, any subsequent changes should be
sufficiently small that incremental patches are the way to apply touchups.

The core problem here is that (lots of) people are flinging patches at
tree-owners before they are sufficiently baked.