Re: [PATCH 6/5] ACPI: DMI blacklist for OSI(Linux)

[Len Brown <lenb@kernel.org>]

On Saturday 19 January 2008 03:16, Andi Kleen wrote:
> Len Brown <lenb@kernel.org> writes:
> > --- a/drivers/acpi/blacklist.c
> > +++ b/drivers/acpi/blacklist.c
> > @@ -1,6 +1,8 @@
> >  /*
> >   *  blacklist.c
> >   *
> > + *  X86 specific ACPI blacklists.
> > + *
> >   *  Check to see if the given machine has a known bad ACPI BIOS
> >   *  or if the BIOS is too old.
> >   *
> > @@ -165,3 +167,578 @@ int __init acpi_blacklisted(void)
> >  
> >  	return blacklisted;
> >  }
> > +#ifdef CONFIG_DMI
> 
> IA64 sets CONFIG_DMI too. So it won't be x86 specific as written.
> Probably shoud check for CONFIG_X86 too.

drivers/acpi/Makefile causes blacklist.c to be X86 specific.

obj-$(CONFIG_X86)               += blacklist.o

that is what I wanted (and IA64 can add their own blacklist if
they need one).  but if IA64 defines CONFIG_DMI,
then I just broke their build b/c acpi_osl_dmi_table will be undefined...

> > +extern void dmi_osi_linux(int enable, const struct dmi_system_id *d);
> 
> That should be in some include, shouldn't it?

yes.

thanks,
-Len