Re: [PATCH 3/4] ACPI: Check for any matching CID when walking namespace.

Andrew Patterson
2008-01-23T19:35:53Z

On Wed, 2008-01-23 at 09:42 -0800, Greg KH wrote:
> On Tue, Jan 22, 2008 at 05:18:22PM -0700, Andrew Patterson wrote:
> > From: Andrew Patterson <andrew.patterson@hp.com>
> >
> > The callback function acpi_ns_get_device_callback called from
> > acpi_get_devices() will check CID's if the HID does not match. This code
> > has a bug where it requires that all CIDs match the HID. Changed the code
> > so that any CID match will do.
> >
> > Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
> > ---
> >
> > drivers/acpi/namespace/nsxfeval.c | 11 ++++++++---
> > 1 files changed, 8 insertions(+), 3 deletions(-)
>
> This should probably go through the ACPI tree, not the PCI tree, right?
>

Yes, but it is needed to get PCIe AER working (at least on the systems
that I have seen). I suspect we will have the same issue with PCIe
hotplug. Len Brown is looking at it.

> thanks,
>
> greg k-h