From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.
Date: Thu, 24 Jan 2008 04:54:42 +0000 [thread overview]
Message-ID: <200801240454.42732.carlos@strangeworlds.co.uk> (raw)
In-Reply-To: <200801232335.03453.lenb@kernel.org>
On Thursday 24 January 2008 04:35:03 Len Brown wrote:
> I'm surprised to discover it uses strstr() and matches
> substrings instead. Is there logic behind that?
As for the exact reason, no idea - you'd have to ask whoever is responsible
for that. It's just a curious thing I've noticed and has come in rather
handy.
As a side effect though, it does avoid lots of nasty unpleasantness with
vendor whitespace padding abuse.
Otherwise, as Acer in particular love to pad many of their DMI entries with
whitespace, we'd be scratching our heads forever as to why an entry doesn't
work if we slip up and miss a whitespace character or two.
So at least from my perspective, substring matching is a good thing.
-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
next prev parent reply other threads:[~2008-01-24 4:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 2:32 deal with OSI(Linux) (v2) Len Brown
2008-01-24 2:32 ` [PATCH 1/8] DMI: move dmi_available declaration to linux/dmi.h Len Brown
2008-01-24 2:32 ` [PATCH 2/8] DMI: create dmi_get_slot() Len Brown
2008-01-24 2:32 ` [PATCH 3/8] ACPI: create acpi_dmi_dump() Len Brown
2008-01-24 2:32 ` [PATCH 4/8] ACPI: on OSI(Linux), print needed DMI rather than requesting dmidecode output Len Brown
2008-01-24 2:32 ` [PATCH 5/8] ACPI: Delete Intel Customer Reference Board (CRB) from OSI(Linux) DMI list Len Brown
2008-01-24 2:32 ` [PATCH 6/8] ACPI: make _OSI(Linux) console messages smarter Len Brown
2008-01-24 2:32 ` [PATCH 7/8] ACPI: Add ThinkPad R61, ThinkPad T61 to OSI(Linux) white-list Len Brown
2008-01-24 2:32 ` [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems Len Brown
2008-01-24 2:55 ` Carlos Corbacho
2008-01-24 4:35 ` Len Brown
2008-01-24 4:54 ` Carlos Corbacho [this message]
2008-01-25 20:36 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801240454.42732.carlos@strangeworlds.co.uk \
--to=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox