Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.

Carlos Corbacho
2008-01-24T04:54:45Z

On Thursday 24 January 2008 04:35:03 Len Brown wrote:
> I'm surprised to discover it uses strstr() and matches
> substrings instead. Is there logic behind that?

As for the exact reason, no idea - you'd have to ask whoever is responsible
for that. It's just a curious thing I've noticed and has come in rather
handy.

As a side effect though, it does avoid lots of nasty unpleasantness with
vendor whitespace padding abuse.

Otherwise, as Acer in particular love to pad many of their DMI entries with
whitespace, we'd be scratching our heads forever as to why an entry doesn't
work if we slip up and miss a whitespace character or two.

So at least from my perspective, substring matching is a good thing.

-Carlos
--
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D