Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.

Len Brown
2008-01-26T02:47:44Z

On Wednesday 23 January 2008 23:54, you wrote:
> On Thursday 24 January 2008 04:35:03 Len Brown wrote:
> > I'm surprised to discover it uses strstr() and matches
> > substrings instead. Is there logic behind that?
>
> As for the exact reason, no idea - you'd have to ask whoever is responsible
> for that. It's just a curious thing I've noticed and has come in rather
> handy.
>
> As a side effect though, it does avoid lots of nasty unpleasantness with
> vendor whitespace padding abuse.
>
> Otherwise, as Acer in particular love to pad many of their DMI entries with
> whitespace, we'd be scratching our heads forever as to why an entry doesn't
> work if we slip up and miss a whitespace character or two.
>
> So at least from my perspective, substring matching is a good thing.

Yes, I've seen DMI entries with trailing whitespace too -- very irritating.

I considered putting quotes around the recent DMI console messages,
but decided against it since we'd more likely get the real dmesg
and copy paste, rather than copying stuff off a screen where whitespace is lost.

I'll delete the longer of the Acer matches int this case,
as it would result in us printing two console messages.

thanks for pointing this out,
-Len