ACPI module for Asus Eee PC

ACPI module for Asus Eee PC

[Eric Cooper]

I happened to look at the patched asus_acpi.c module that was posted
by Asus for the Eee PC and noticed that it's 75% dead code -- the Eee
PC support is just stuck on at the end.  And of course it conflicts
with the real asus_acpi.ko in any kernel package.

So I cleaned it up, renamed it eeepc_acpi, and packaged it as a
separate out-of-kernel Debian package that can be built with
module-assistant.

Here's the wc comparison:
 1907  6180 50911 asus_acpi.c
  453  1434 13037 eeepc_acpi.c

When I proposed to add this package to Debian, it was also suggested
that I contact this list to see about including it in the mainline.
If I can help with that in any way, please let me know.  I'm not
subscribed, so please CC me on any replies.

The source is at http://www.cs.cmu.edu/~ecc/eeepc-acpi_1.0.tar.gz,
and the Debian package is at
    http://www.cs.cmu.edu/~ecc/eeepc-acpi_1.0-1.{dsc,diff.gz}

Cheers,
Eric

-- 
Eric Cooper             e c c @ c m u . e d u

Re: ACPI module for Asus Eee PC

[Carlos Corbacho]

On Saturday 26 January 2008 14:48:24 Eric Cooper wrote:
> I happened to look at the patched asus_acpi.c module that was posted
> by Asus for the Eee PC and noticed that it's 75% dead code -- the Eee
> PC support is just stuck on at the end.  And of course it conflicts
> with the real asus_acpi.ko in any kernel package.
>
> So I cleaned it up, renamed it eeepc_acpi, and packaged it as a
> separate out-of-kernel Debian package that can be built with
> module-assistant.

To submit a driver, it needs to be as a patch against the ACPI Git tree 'test' 
branch.

New laptop drivers should:

1) Be in drivers/misc (asus_acpi is the only leftover in drivers/acpi - 
everything else has already been moved, and no new laptop drivers will be 
accepted in drivers/acpi)

2) proc is deprecated for new drivers - you should be using sysfs

3) #if LINUX_KERNEL_VERSION is an absolute no-no in upstream kernel code. Any 
such instances should be stripped out of the code.

4) Patches should be run through scripts/checkpatch.pl, and new drivers 
especially should be checkpatch clean - you will find it flags up quite a few 
style problems with the code.

If you can address these and then resubmit a proper patch, then you will stand 
a chance of getting this reviewed and accepted into the mainline kernel.

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D

Re: ACPI module for Asus Eee PC

[Corentin CHARY]

Hi,
I'm the maintener of asus_acpi and asus-laptop.

On Saturday 26 January 2008 15:48:24 Eric Cooper wrote:
> I happened to look at the patched asus_acpi.c module that was posted
> by Asus for the Eee PC and noticed that it's 75% dead code
Where and when asus has posted that patch ?

> So I cleaned it up, renamed it eeepc_acpi, and packaged it as a
> separate out-of-kernel Debian package that can be built with
> module-assistant.
>
> Here's the wc comparison:
>  1907  6180 50911 asus_acpi.c
>   453  1434 13037 eeepc_acpi.c
I will look your eeepc_acpi.c, but asus_acpi is clearly deprecated.
I could try to port that to the new asus-laptop.c.


-- 
Corentin 'Iksaif' CHARY
http://xf.iksaif.net

Re: ACPI module for Asus Eee PC

[Eric Cooper]

On Wed, Jan 30, 2008 at 07:10:46PM +0100, Corentin CHARY wrote:
> I'm the maintener of asus_acpi and asus-laptop.
> 
> On Saturday 26 January 2008 15:48:24 Eric Cooper wrote:
> > I happened to look at the patched asus_acpi.c module that was posted
> > by Asus for the Eee PC and noticed that it's 75% dead code
> Where and when asus has posted that patch ?

ftp://ftp.asus.com/pub/ASUS/EeePC/701/ASUS_ACPI_071126.rar
(Note that this "patch" makes it support only the Eee PC.)

> I will look your eeepc_acpi.c, but asus_acpi is clearly deprecated.
> I could try to port that to the new asus-laptop.c.

That would be great.  Also, Asus has apparently assigned some
engineers to liaison with the Linux community -- AndrewLee and cwhuang
on oftc/#debian-eeepc.

-- 
Eric Cooper             e c c @ c m u . e d u

Re: ACPI module for Asus Eee PC

[Corentin CHARY]

On Wednesday 30 January 2008 19:21:46 Eric Cooper wrote:
> On Wed, Jan 30, 2008 at 07:10:46PM +0100, Corentin CHARY wrote:
> > I'm the maintener of asus_acpi and asus-laptop.
> >
> > On Saturday 26 January 2008 15:48:24 Eric Cooper wrote:
> > > I happened to look at the patched asus_acpi.c module that was posted
> > > by Asus for the Eee PC and noticed that it's 75% dead code
> >
> > Where and when asus has posted that patch ?
>
> ftp://ftp.asus.com/pub/ASUS/EeePC/701/ASUS_ACPI_071126.rar
> (Note that this "patch" makes it support only the Eee PC.)
>
> > I will look your eeepc_acpi.c, but asus_acpi is clearly deprecated.
> > I could try to port that to the new asus-laptop.c.
>
> That would be great.  Also, Asus has apparently assigned some
> engineers to liaison with the Linux community -- AndrewLee and cwhuang
> on oftc/#debian-eeepc.

What's oftc ? I guess it's an irc server... but can't find the host :p.

-- 
Corentin 'Iksaif' CHARY
http://xf.iksaif.net