From mboxrd@z Thu Jan 1 00:00:00 1970 From: maximilian attems Subject: Re: [PATCH] ACPI: battery: add sysfs serial number Date: Sun, 3 Feb 2008 12:02:36 +0100 Message-ID: <20080203110236.GC4941@stro.at> References: <1201024010-6103-1-git-send-email-max@stro.at> <47962F29.7000102@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from baikonur.stro.at ([213.239.196.228]:58721 "EHLO baikonur.stro.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752980AbYBCLDT (ORCPT ); Sun, 3 Feb 2008 06:03:19 -0500 Content-Disposition: inline In-Reply-To: <47962F29.7000102@suse.de> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Alexey Starikovskiy Cc: Len Brown , linux-acpi@vger.kernel.org Dear Len Brown, could you please merged acked patch, don't feel like merging sysfs file patches in Debian on my own. thanks for feedback -- maks On Tue, 22 Jan 2008, Alexey Starikovskiy wrote: > ACK > maximilian attems wrote: >> egrep serial /proc/acpi/battery/BAT0/info >> serial number: 32090 >> >> serial number can tell you from the imminent danger >> of beeing set on fire. >> >> Signed-off-by: maximilian attems >> --- >> drivers/acpi/battery.c | 5 +++++ >> drivers/power/power_supply_sysfs.c | 1 + >> include/linux/power_supply.h | 1 + >> 3 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c >> index c4a769d..f6215e8 100644 >> --- a/drivers/acpi/battery.c >> +++ b/drivers/acpi/battery.c >> @@ -194,6 +194,9 @@ static int acpi_battery_get_property(struct power_supply *psy, >> case POWER_SUPPLY_PROP_MANUFACTURER: >> val->strval = battery->oem_info; >> break; >> + case POWER_SUPPLY_PROP_SERIAL_NUMBER: >> + val->strval = battery->serial_number; >> + break; >> default: >> return -EINVAL; >> } >> @@ -212,6 +215,7 @@ static enum power_supply_property charge_battery_props[] = { >> POWER_SUPPLY_PROP_CHARGE_NOW, >> POWER_SUPPLY_PROP_MODEL_NAME, >> POWER_SUPPLY_PROP_MANUFACTURER, >> + POWER_SUPPLY_PROP_SERIAL_NUMBER, >> }; >> static enum power_supply_property energy_battery_props[] = { >> @@ -226,6 +230,7 @@ static enum power_supply_property energy_battery_props[] = { >> POWER_SUPPLY_PROP_ENERGY_NOW, >> POWER_SUPPLY_PROP_MODEL_NAME, >> POWER_SUPPLY_PROP_MANUFACTURER, >> + POWER_SUPPLY_PROP_SERIAL_NUMBER, >> }; >> #endif >> diff --git a/drivers/power/power_supply_sysfs.c >> b/drivers/power/power_supply_sysfs.c >> index 249f61b..8feaa48 100644 >> --- a/drivers/power/power_supply_sysfs.c >> +++ b/drivers/power/power_supply_sysfs.c >> @@ -117,6 +117,7 @@ static struct device_attribute power_supply_attrs[] = { >> /* Properties of type `const char *' */ >> POWER_SUPPLY_ATTR(model_name), >> POWER_SUPPLY_ATTR(manufacturer), >> + POWER_SUPPLY_ATTR(serial_number), >> }; >> static ssize_t power_supply_show_static_attrs(struct device *dev, >> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h >> index 606c095..300159b 100644 >> --- a/include/linux/power_supply.h >> +++ b/include/linux/power_supply.h >> @@ -101,6 +101,7 @@ enum power_supply_property { >> /* Properties of type `const char *' */ >> POWER_SUPPLY_PROP_MODEL_NAME, >> POWER_SUPPLY_PROP_MANUFACTURER, >> + POWER_SUPPLY_PROP_SERIAL_NUMBER, >> }; >> enum power_supply_type {