linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] WMI patches for acpi-test (v2)
@ 2008-02-05  2:16 Carlos Corbacho
  2008-02-05  2:17 ` [PATCH 1/5] ACPI: WMI: Add ACPI-WMI mapping driver Carlos Corbacho
                   ` (5 more replies)
  0 siblings, 6 replies; 31+ messages in thread
From: Carlos Corbacho @ 2008-02-05  2:16 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

Len,

These patches replace the previous five you have in acpi-test - due to the
changes to patch #2 (the sysfs support), and some other problems that turned
up in some extra testing with it, I'd prefer if you replace the original patch
series with this one.

Any further patches can then safely come as incremental ones on top of this
series.

Also, two other things:

1) Would you be able to send me a copy of the DSDT for your Lenovo T61? I'd be
interested to have a look at what Lenovo are doing with WMI.

2) Do you know of any IA64 systems using ACPI-WMI? At the moment, WMI will work
on x86 and hopefully IA64, but if it turns out that no vendor has or ever will
implement ACPI-WMI on IA64, then we could safely drop it there.

-Carlos

===

Patch #1: (WMI - driver and in kernel interface) - Minor clean up

* Delete 'default m' from Kconfig (as per your changes)
* Minor fix to MAINTAINERS (s/Supported/Maintained/ - oversight on my part)

====

Patch #2: (acer-wmi) - MAINTAINERS

* Add me to MAINTAINERS

====

Patch #3: (tc1100-wmi) - MAINTAINERS

* Add me to MAINTAINERS ('Odd Fixes' only, since I don't have the hardware)

RFC only, needs actual testing on the hardware, and probably very broken.
Waiting on Matthew Garrett to get some free time to test this.

I'd ideally like someone to test this on the hardware before I drop the 'RFC' or
am happy with this going upstream.

====

Patch #4: (WMI sysfs interface) - Various large fixups

* Merged with bus ID length patch (for future bisection purposes)

* Added new Kconfig option and ifdef's to make sysfs support optional (and try
  to make it clear that at the moment, it's a development & testing option only)

* Fixed various nasty bugs - crashes, memory leaks, etc (including one that
  prevented WMI unloading if sysfs support was enabled)

* Drop the RFC

====

Patch #5: (WMI documentation) - New

Some simple documentation of the in kernel and sysfs (userspace) WMI interface.

Len:

'data' is a binary file, since WMI provides no information on what is
returned by any given WMI method/ data block, so we don't try and do anything
with it - just return whatever the ACPI buffer contains. You also need to set
'instance' first.

To do anything useful with the sysfs interface, you'll probably need something
that can:

A) Set 'instance'
B) Read 'data' for the given GUID
C) Knows what is being returned
D) Can turn that into something useful to output back

In MS land, (C) is usually provided by a MOF file - since we tend not to have
these available, the only alternative is to look at the DSDT and work out what
size structure you need to hold the returned data.
---

Carlos Corbacho (5):
      ACPI: WMI: Add documentation
      ACPI: WMI: Add sysfs userspace interface
      [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
      acer-wmi: Add driver for newer Acer laptops
      ACPI: WMI: Add ACPI-WMI mapping driver


 Documentation/acpi/wmi.txt |  131 +++++
 MAINTAINERS                |   19 +
 drivers/acpi/Kconfig       |   20 +
 drivers/acpi/Makefile      |    1 
 drivers/acpi/wmi.c         | 1253 ++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/Kconfig       |   25 +
 drivers/misc/Makefile      |    2 
 drivers/misc/acer-wmi.c    | 1109 +++++++++++++++++++++++++++++++++++++++
 drivers/misc/tc1100-wmi.c  |  290 ++++++++++
 include/linux/acpi.h       |   21 +
 10 files changed, 2871 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/acpi/wmi.txt
 create mode 100644 drivers/acpi/wmi.c
 create mode 100644 drivers/misc/acer-wmi.c
 create mode 100644 drivers/misc/tc1100-wmi.c


^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI patches for acpi-test
@ 2008-02-02 12:17 Carlos Corbacho
  2008-02-02 12:17 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2008-02-02 12:17 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

Len,

Can you please review, and hopefully apply, at least the first two patches in
this series, as I would like to get them into acpi-test (then -mm and eventually
2.6.26-rc1).

It's a little late now to put these into 2.6.25-rc1, and I don't want to
miss another merge window - so the sooner these are looked at by you, the sooner
I can address any concerns and we can have these ready for the 2.6.26-rc1
window.

-Carlos

===

Patch #1: (WMI - driver and in kernel interface) - Minor clean up

Replace leftover occurences of 'x == NULL' with '!x'

Len: For you to review and to be applied to acpi-test.

====

Patch #2: (acer-wmi) - New DMI entry, mail LED detection fix, mismatch fix

* Don't fail if we can't detect a mail LED on AMW0 systems
* Add an EC quirk for the Acer Aspire 9110
* Fix section mismatch warnings

Len: For you to review and to be applied to acpi-test.

====

Patch #3: (tc1100-wmi) - No Change

RFC only, needs actual testing on the hardware, and probably very broken.
Waiting on Matthew Garrett to get some free time to test this.

====

Patch #4: (WMI sysfs interface) - No Change

RFC only (see patch #5 for reason and discussion). Adds interface under
/sys/devices/virtual/wmi

Also adds a function to return the (virtual) device associated with a GUID for
use by other parts of the kernel that want to set a parent device.

Len: To review (but not to apply yet, unless you want to apply patch #5 as well)

====

Patch #5: (WMI sysfs workaround) - No Change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id
length (Kay Sievers is apparently working on this, ref Greg KH[1]).

Len:

Apparently, the necessary fixes _might_ go into 2.6.25 as well, or worst case
scenario is 2.6.26[2]. So we can either:

1) Hold off on patch #4 until the necessary fixes go in (this might be 2.6.25
if we're lucky, or we end up putting off WMI sysfs support until 2.6.26)

or

2) Apply patch #4, and #5 on top as a temporary hack, and then revert #5 as
soon as the necessary changes go in. (For bisection purposes, #4 and #5 should
be merged if we go ahead with this).

I don't know what would be the best solution here.

[1] http://lkml.org/lkml/2007/12/4/30
[2] http://www.nabble.com/Re:-Fix-Firmware-class-name-collision-p14352966.html
---

Carlos Corbacho (5):
      [WIP] ACPI: WMI: Limit size of device string to 19 characters
      [RFC] ACPI: WMI: Add sysfs userspace interface
      [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
      acer-wmi: Add driver for newer Acer laptops
      ACPI: WMI: Add ACPI-WMI mapping driver


 MAINTAINERS               |    7 
 drivers/acpi/Kconfig      |   11 
 drivers/acpi/Makefile     |    1 
 drivers/acpi/wmi.c        | 1190 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/Kconfig      |   25 +
 drivers/misc/Makefile     |    2 
 drivers/misc/acer-wmi.c   | 1109 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/tc1100-wmi.c |  290 +++++++++++
 include/linux/acpi.h      |   21 +
 9 files changed, 2656 insertions(+), 0 deletions(-)
 create mode 100644 drivers/acpi/wmi.c
 create mode 100644 drivers/misc/acer-wmi.c
 create mode 100644 drivers/misc/tc1100-wmi.c


^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI
@ 2008-01-18 23:58 Carlos Corbacho
  2008-01-18 23:58 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2008-01-18 23:58 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

ANYWR - Another New Year WMI release

Len,

Can you please review at least the first two patches in this series, as I
would still really like to try and get them into 2.6.25.

-Carlos

===

Patch #1: (WMI - driver and in kernel interface) - Fix ACPI debug issues

Fix the compile errors with ACPI debugging enabled.

Len: For you to review, and to go upstream.

====

Patch #2: (acer-wmi) - No change

Len: For you to review, and to go upstream.

====

Patch #3: (tc1100-wmi) - No Change

RFC only, needs actual testing on the hardware, and probably very broken.
Waiting on Matthew Garrett to get some free time to test this.

====

Patch #4: (WMI sysfs interface) - Added new in-kernel function

RFC only (see patch #5 for reason and discussion). Adds interface under
/sys/devices/virtual/wmi

Also adds a function to return the (virtual) device associated with a GUID for
use by other parts of the kernel that want to set a parent device.

====

Patch #5: (WMI sysfs workaround) - No change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id
length (Kay Sievers is apparently working on this, ref Greg KH[1]).

Apparently, the necessary fixes _might_ go into 2.6.25 as well, or worst case
scenario is 2.6.26[2]. So we can either:

1) Hold off on patch #4 until the necessary fixes go in (this might be 2.6.25
if we're lucky, or we end up putting off WMI sysfs support until 2.6.26)

or

2) Apply patch #4, and #5 on top as a temporary hack, and then revert #5 as
soon as the necessary changes go in. (For bisection purposes, #4 and #5 should
be merged if we go ahead with this).

I don't know what would be the best solution here.

[1] http://lkml.org/lkml/2007/12/4/30
[2] http://www.nabble.com/Re:-Fix-Firmware-class-name-collision-p14352966.html
---

Carlos Corbacho (5):
      [WIP] ACPI: WMI: Limit size of device string to 19 characters
      [RFC] ACPI: WMI: Add sysfs userspace interface
      [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
      acer-wmi: Add driver for newer Acer laptops
      ACPI: WMI: Add ACPI-WMI mapping driver


 MAINTAINERS               |    7 
 drivers/acpi/Kconfig      |   11 
 drivers/acpi/Makefile     |    1 
 drivers/acpi/wmi.c        | 1190 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/Kconfig      |   25 +
 drivers/misc/Makefile     |    2 
 drivers/misc/acer-wmi.c   | 1100 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/tc1100-wmi.c |  290 +++++++++++
 include/linux/acpi.h      |   21 +
 9 files changed, 2647 insertions(+), 0 deletions(-)
 create mode 100644 drivers/acpi/wmi.c
 create mode 100644 drivers/misc/acer-wmi.c
 create mode 100644 drivers/misc/tc1100-wmi.c



^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI
@ 2008-01-12  2:20 Carlos Corbacho
  2008-01-12  2:20 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2008-01-12  2:20 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

ANYWR - A New Year WMI release

Len,

Can you please review at least the first two patches in this series, as I
would really like to try and get them into 2.6.25.

-Carlos

===

Patch #1: (WMI - driver and in kernel interface) - No change

Len: For you to review, and to go upstream.

====

Patch #2: (acer-wmi)

Added more device autodetection. Also, fixed setting bluetooth and wireless
on older AMW0 V2 laptops, and improved the error handling code on driver
registration.

(I am currently working on rfkill support, but have been running into some
strange problems with rfkill-input, so I'll release that as a future patch
on top of this when it's done. Until then, though, this patch still works
as-is).

Len: For you to review, and to go upstream.

====

Patch #3: (tc1100-wmi) - No Change

RFC only, needs actual testing on the hardware, and probably very broken.
Waiting on Matthew Garrett to get some free time to test this.

====

Patch #4: (WMI sysfs interface) - No Change

RFC only (see patch #5 for reason). Adds interface under
/sys/devices/virtual/wmi

Matthew: Do you want me to fold patch #5 into this?

====

Patch #5: (WMI sysfs workaround) - No change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id
length (Kay Sievers is apparently working on this, ref Greg KH[1]).

[1] http://lkml.org/lkml/2007/12/4/30
---

Carlos Corbacho (5):
      [WIP] ACPI: WMI: Limit size of device string to 19 characters
      [RFC] ACPI: WMI: Add sysfs userspace interface
      [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets
      acer-wmi: Add driver for newer Acer laptops
      ACPI: WMI: Add ACPI-WMI mapping driver


 MAINTAINERS               |    7 
 drivers/acpi/Kconfig      |   11 
 drivers/acpi/Makefile     |    1 
 drivers/acpi/wmi.c        | 1171 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/Kconfig      |   25 +
 drivers/misc/Makefile     |    2 
 drivers/misc/acer-wmi.c   | 1100 ++++++++++++++++++++++++++++++++++++++++++
 drivers/misc/tc1100-wmi.c |  290 +++++++++++
 include/linux/acpi.h      |   20 +
 9 files changed, 2627 insertions(+), 0 deletions(-)
 create mode 100644 drivers/acpi/wmi.c
 create mode 100644 drivers/misc/acer-wmi.c
 create mode 100644 drivers/misc/tc1100-wmi.c



^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI
@ 2007-12-27 15:38 Carlos Corbacho
  2007-12-27 15:38 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2007-12-27 15:38 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

ACSWR - A Christmas Sale WMI release

Patch #1: (WMI - driver and in kernel interface)

Added per GUID event handling callbacks, as per Matthew's suggestion.

Len:
For review, and to go upstream.

(Bar the EC stuff, this code has also been inflic^^^^tested by acer_acpi users
with my 0.10 releases, so I'm confident on Acer hardware at least that it won't
break horribly).

Patch #2: (acer-wmi)

Add device detection for bluetooth and maximum brightness (removes more hard
coded EC quirks). Also simplified some of the code.

Len:
For review, and to go upstream.

Patch #3: (tc1100-wmi) - No Change

RFC only, needs actual testing on the hardware, and probably very broken.
Waiting on Matthew Garrett to get some free time to test this.

Patch #4: (WMI sysfs interface) - No Change

RFC only (see patch #5 for reason). Adds interface under
/sys/devices/virtual/wmi

Matthew - Do you want me to fold patch #5 into this?

Patch #5: (WMI sysfs workaround) - No change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id
length (Kay Sievers is apparently working on this, ref Greg KH[1]).

-Carlos

[1] http://lkml.org/lkml/2007/12/4/30

^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI
@ 2007-12-17  0:23 Carlos Corbacho
  2007-12-17  0:23 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2007-12-17  0:23 UTC (permalink / raw)
  To: linux-acpi; +Cc: Len Brown, Matthew Garrett, Alexey Starikovskiy

Another WMI release.

Patch #1: (WMI - initial driver and in kernel interface)

Big change here is putting in a basic EC region handler - which is
mostly a shameless rip off of the EC driver's acpi_ec_space_handler,
with the exception that WMI doesn't need to care about the EC device,
and just calls ec_{read,write} instead.

Therefore, CC'ing Alexey for the EC bit.

For review, and hopefully to go up to 2.6.25

Patch #2: (acer-wmi) - No Change

For review, and (rather tentatively here) 2.6.25 material?

Patch #3: (tc1100-wmi)

RFC only, needs actual testing on the hardware, and probably very broken. 
Waiting on Matthew Garrett to get some free time to test this.

Bluetooth renamed to jogdial, as per comments from Joshua Wise.

Patch #4: (WMI sysfs interface) - No Change

RFC only (see patch #5 for reason). Adds interface 
under /sys/devices/virtual/wmi

Changes: Added 'string' file to each GUID, which reports whether the GUID has 
the 'string' flag set (userspace needs to know for converting from its' 
format to ASCII and back).

Patch #5: (WMI sysfs workaround) - No change

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id 
length (Kay Sievers is apparently working on this, ref Greg KH[1]). This 
should _NOT_ be applied to any upstream kernel.

-Carlos

[1] http://lkml.org/lkml/2007/12/4/30

^ permalink raw reply	[flat|nested] 31+ messages in thread
* [PATCH 0/5] WMI
@ 2007-12-12  2:01 Carlos Corbacho
  2007-12-12  2:08 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
  0 siblings, 1 reply; 31+ messages in thread
From: Carlos Corbacho @ 2007-12-12  2:01 UTC (permalink / raw)
  To: linux-acpi; +Cc: lenb, Matthew Garrett

So, here comes the next release of WMI.

Patch #1: (WMI - initial driver and in kernel interface)

One big change - add a fix to handle querying data GUIDs that violate the WMI 
spec with setting the 'expensive' flag (one case seen in the wild on a newer 
Acer laptop) - GUID declares the block as expensive, but there is no 
accompanying WCxx method.

A few minor taste cleanups thrown in (replacing (a == NULL) with (!a)).

For review, and hopefully to go up to 2.6.25 

Patch #2: (acer-wmi)

Add a few more DMI matched EC quirks in since last time. No other code 
changes. 

For review, and (rather tentatively here) 2.6.25 material?

Patch #3: (tc1100-wmi)

RFC only, needs actual testing on the hardware, and probably very broken. 
Waiting on Matthew Garrett to get some free time to test this.

Patch #4: (WMI sysfs interface)

RFC only (see patch #5 for reason). Adds interface 
under /sys/devices/virtual/wmi

Changes: Added 'string' file to each GUID, which reports whether the GUID has 
the 'string' flag set (userspace needs to know for converting from its' 
format to ASCII and back).

Patch #5: (WMI sysfs workaround)

Temporary hack, needed to get patch #4 working, due to a limitation on bus_id 
length (Kay Sievers is apparently working on this, ref Greg KH[1]). This 
should _NOT_ be applied to any upstream kernel.

-Carlos

[1] http://lkml.org/lkml/2007/12/4/30
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D

^ permalink raw reply	[flat|nested] 31+ messages in thread

end of thread, other threads:[~2009-04-29 21:10 UTC | newest]

Thread overview: 31+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-05  2:16 [PATCH 0/5] WMI patches for acpi-test (v2) Carlos Corbacho
2008-02-05  2:17 ` [PATCH 1/5] ACPI: WMI: Add ACPI-WMI mapping driver Carlos Corbacho
2008-02-05  2:17 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2008-02-05  2:17 ` [PATCH 3/5] [RFC] tc1100-wmi: Add driver for HP Compaq TC1100 Tablets Carlos Corbacho
2008-02-05  2:17 ` [PATCH 4/5] ACPI: WMI: Add sysfs userspace interface Carlos Corbacho
2008-02-05 22:59   ` Carlos Corbacho
2008-02-06 11:36     ` Carlos Corbacho
2008-02-07  3:49       ` Len Brown
2008-08-27 13:53   ` Matthew Garrett
2008-08-27 20:21     ` Carlos Corbacho
2008-08-27 20:44       ` Matthew Garrett
2008-08-29 15:05         ` [PATCH] Documentation: Provide Documenation/udev.txt Thomas Renninger
2008-08-29 15:30           ` Kay Sievers
2008-08-29 15:35             ` Thomas Renninger
2009-04-29 20:38       ` [PATCH 4/5] ACPI: WMI: Add sysfs userspace interface Matthew Garrett
2009-04-29 21:09         ` Carlos Corbacho
2008-02-05  2:17 ` [PATCH 5/5] ACPI: WMI: Add documentation Carlos Corbacho
2008-02-05  2:25   ` [PATCH 5/5] ACPI: WMI: Add initial documentation Carlos Corbacho
2008-02-06  3:12     ` Randy Dunlap
2008-02-06 10:51       ` Carlos Corbacho
2008-02-05 21:03 ` [PATCH 0/5] WMI patches for acpi-test (v2) Len Brown
2008-02-05 21:18   ` Carlos Corbacho
2008-02-06  0:35     ` Bjorn Helgaas
2008-02-06  2:03       ` Carlos Corbacho
2008-02-06  6:30         ` Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2008-02-02 12:17 [PATCH 0/5] WMI patches for acpi-test Carlos Corbacho
2008-02-02 12:17 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2008-01-18 23:58 [PATCH 0/5] WMI Carlos Corbacho
2008-01-18 23:58 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2008-01-12  2:20 [PATCH 0/5] WMI Carlos Corbacho
2008-01-12  2:20 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2007-12-27 15:38 [PATCH 0/5] WMI Carlos Corbacho
2007-12-27 15:38 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2007-12-17  0:23 [PATCH 0/5] WMI Carlos Corbacho
2007-12-17  0:23 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho
2007-12-12  2:01 [PATCH 0/5] WMI Carlos Corbacho
2007-12-12  2:08 ` [PATCH 2/5] acer-wmi: Add driver for newer Acer laptops Carlos Corbacho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).