Re: [PATCH 053/112] the generic thermal sysfs driver

Randy Dunlap
2008-02-07T22:12:07Z

Len Brown wrote:
> Thanks for the review, Randy.
>
> I've corrected the issues you pointed out, as well as
> run the doc through ispell and run thermal.c through Lindent.
>
> I've left the goto labels where Lindent put them.
> If there is a Linux style consensus on that issue,
> perhaps the Linux community can enhance Lindent?

I'd say that there is concensus but no one to touch Lindent.
[Similarly for kconfig select dependency problems. :( ]

> (I'm not going to move a bunch of labels around,
> just to have the next Lindent sweep move them back)

Lindent has several other known issues as far as Linux kernel
is concerned. I.e., it's not a fine tool to use and not review
what it did.

> Also, regarding the kernel-doc syntax, that too
> would be a good thing for Lindent, or some other tool
> to do for us -- or at least to complain about for us:-)

So noted, added to the todo list.

Thanks.

> thanks,
> -Len
>
> From 54c82f9ae5b2106cc79633a611367883c374ad3f Mon Sep 17 00:00:00 2001
> From: Len Brown <len.brown@intel.com>
> Date: Thu, 7 Feb 2008 16:55:08 -0500
> Subject: [PATCH] ACPI: thermal: syntax, spelling, kernel-doc
> Organization: Intel Open Source Technology Center
>
> Reviewed-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> Documentation/thermal/sysfs-api.txt | 23 ++++++++--------
> drivers/thermal/Kconfig | 4 +-
> drivers/thermal/thermal.c | 49 ++++++++++++++++++++---------------
> 3 files changed, 41 insertions(+), 35 deletions(-)

--
~Randy