RE: [linux-pm] [PATCH] CPUidle: compile fix for non-x86

Pallipadi, Venkatesh
2008-01-31T18:44:21Z

>-----Original Message-----
>From: Rafael J. Wysocki [mailto:rjw@sisk.pl]
>Sent: Wednesday, January 30, 2008 2:17 AM
>To: Len Brown
>Cc: ACPI Devel Maling List; Pallipadi, Venkatesh; Kevin Hilman
>Subject: Fwd: [linux-pm] [PATCH] CPUidle: compile fix for non-x86
>
>Hi,
>
>Please have a look at this.
>
>Rafael
>
>
> Wrap cpu_idle_wait() in an x86 #ifdef since it's x86 only.
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index d2fabe7..4d0f9b0 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -82,7 +82,9 @@ void cpuidle_uninstall_idle_handler(void)
> {
> if (enabled_devices && (pm_idle != pm_idle_old)) {
> pm_idle = pm_idle_old;
> +#ifdef CONFIG_X86
> cpu_idle_wait();
> +#endif
>

The archs that do not have cpu_idle_wait() and has more than one CPU
will need something equivalent to cpu_idle_wait() to kick all other CPUs
out of idle loop.
The reason being we do not want another CPU to be in idle loop that is
being uninstalled here.

Do you have more than one logical CPU on your platform?

Thanks,
Venki