[PATCH 0/2] WMI based driver fixes for 2.6.25

[PATCH 0/2] WMI based driver fixes for 2.6.25

[Carlos Corbacho]

The following series is two small fixes to the WMI based drivers:

1) Make tc1100-wmi depend on EXPERIMENTAL, since its code base is completely
untested. (This is just a resend of the patch I sent earlier today).

2) Fix setting the backlight on acer-wmi for older Acer laptops.

These are both candidates for 2.6.25, but they can wait until -rc1 if need
be.

-Carlos
---

Carlos Corbacho (2):
      acer-wmi: Fix backlight on AMW0 (V1) laptops
      tc1100-wmi: Mark as experimental


 drivers/misc/Kconfig    |    3 ++-
 drivers/misc/acer-wmi.c |    6 ++----
 2 files changed, 4 insertions(+), 5 deletions(-)

[PATCH 1/2] tc1100-wmi: Mark as experimental

[Carlos Corbacho]

tc1100-wmi has not undergone as much testing as acer-wmi, so it certainly
should be marked as experimental as well until we get more user feedback.

Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
CC: Len Brown <lenb@kernel.org>
---

 drivers/misc/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 4e7f000..e6c4892 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -143,8 +143,9 @@ config FUJITSU_LAPTOP
 	  If you have a Fujitsu laptop, say Y or M here.
 
 config TC1100_WMI
-	tristate "HP Compaq TC1100 Tablet WMI Extras"
+	tristate "HP Compaq TC1100 Tablet WMI Extras (EXPERIMENTAL)"
 	depends on X86 && !X86_64
+	depends on EXPERIMENTAL
 	depends on ACPI
 	select ACPI_WMI
 	---help---

[PATCH 2/2] acer-wmi: Fix backlight on AMW0 (V1) laptops

[Carlos Corbacho]

There is some leftover cruft from the old quirk infrastructure that causes
us to be unable to set the backlight on older laptops.

Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
CC: Len Brown <lenb@kernel.org>
---

 drivers/misc/acer-wmi.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)


diff --git a/drivers/misc/acer-wmi.c b/drivers/misc/acer-wmi.c
index a4d6775..d7aea93 100644
--- a/drivers/misc/acer-wmi.c
+++ b/drivers/misc/acer-wmi.c
@@ -428,11 +428,9 @@ static acpi_status AMW0_set_u32(u32 value, u32 cap, struct wmi_interface *iface)
 		if (value > max_brightness)
 			return AE_BAD_PARAMETER;
 		switch (quirks->brightness) {
-		case 1:
-			return ec_write(0x83, value);
 		default:
-			return AE_BAD_ADDRESS;
-		break;
+			return ec_write(0x83, value);
+			break;
 		}
 	default:
 		return AE_BAD_ADDRESS;

Re: [PATCH 0/2] WMI based driver fixes for 2.6.251 & 2

[Len Brown]

1 & 2 applied,

thanks,
-len

On Friday 08 February 2008 18:51, Carlos Corbacho wrote:
> The following series is two small fixes to the WMI based drivers:
> 
> 1) Make tc1100-wmi depend on EXPERIMENTAL, since its code base is completely
> untested. (This is just a resend of the patch I sent earlier today).
> 
> 2) Fix setting the backlight on acer-wmi for older Acer laptops.
> 
> These are both candidates for 2.6.25, but they can wait until -rc1 if need
> be.
> 
> -Carlos
> ---
> 
> Carlos Corbacho (2):
>       acer-wmi: Fix backlight on AMW0 (V1) laptops
>       tc1100-wmi: Mark as experimental
> 
> 
>  drivers/misc/Kconfig    |    3 ++-
>  drivers/misc/acer-wmi.c |    6 ++----
>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>