From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [Bug-fix]:2.6.25-rc0 Generic thermal management [Patch 1/2]: validating input parameters Date: Mon, 11 Feb 2008 13:38:27 -0800 Message-ID: <20080211133827.16140ba0.akpm@linux-foundation.org> References: <05B550FD4BD2014E841D83547B62600802A3A1B0@bgsmsx411.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:52318 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754318AbYBKVrW (ORCPT ); Mon, 11 Feb 2008 16:47:22 -0500 In-Reply-To: <05B550FD4BD2014E841D83547B62600802A3A1B0@bgsmsx411.gar.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Thomas, Sujith" Cc: lenb@kernel.org, mingo@elte.hu, torvalds@linux-foundation.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org, rui.zhang@intel.com On Mon, 11 Feb 2008 15:57:06 +0530 "Thomas, Sujith" wrote: > From: Thomas Sujith > > Added sanity checks for interface functions in thermal with > other modules such as fan, processor, video etc.. > > Signed-off-by: Thomas Sujith > --- > drivers/thermal/thermal.c | 69 > +++++++++++++++++++++++++++++----------------- The patch is fairly seriously wordwrapped. > 1 files changed, 44 insertions(+), 25 deletions(-) > > Index: linux-2.6.24-rc3/drivers/thermal/thermal.c > =================================================================== > --- linux-2.6.24-rc3.orig/drivers/thermal/thermal.c > +++ linux-2.6.24-rc3/drivers/thermal/thermal.c > @@ -301,13 +301,27 @@ int thermal_zone_bind_cooling_device(str > { > struct thermal_cooling_device_instance *dev; > struct thermal_cooling_device_instance *pos; > + struct thermal_zone_device *pos1; > + struct thermal_cooling_device *pos2; > int result; > > + if (!tz || !cdev) > + return -EINVAL; Is this change actually needed? It's sloppy for a caller to be passing invalid arguments into a callee, and it's not good for the callee to just hide that sloppiness. > - return NULL; > + return ERR_PTR(-EINVAL); the patch adds several spaces like this in places where we don't normally put them.