From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled
Date: Tue, 12 Feb 2008 16:12:25 +0100
Message-ID: <20080212151225.GA5415@elte.hu>
References: <200802080145.16774.lenb@kernel.org> <20080211091743.GA16459@elte.hu> <200802111923.31736.carlos@strangeworlds.co.uk> <200802111955.04562.carlos@strangeworlds.co.uk> <alpine.LFD.1.00.0802112038360.2920@woody.linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:38133 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753926AbYBLPNY (ORCPT <rfc822;linux-acpi@vger.kernel.org>);
	Tue, 12 Feb 2008 10:13:24 -0500
Content-Disposition: inline
In-Reply-To: <alpine.LFD.1.00.0802112038360.2920@woody.linux-foundation.org>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>, Len Brown <lenb@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> @@ -673,11 +673,11 @@ static int __init acpi_wmi_init(void)
>  {
>  	acpi_status result;
>  
> +	INIT_LIST_HEAD(&wmi_blocks.list);
> +
>  	if (acpi_disabled)
>  		return -ENODEV;
>  
> -	INIT_LIST_HEAD(&wmi_blocks.list);
> -

test results: i've turned the WMI options back on earlier today on 
latest -git which has your patch above, and those crashes i reported 
disappeared. So the problem is fixed.

	Ingo