From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-acpi@vger.kernel.org
Subject: Re: i386 warnings in acpi-test
Date: Sun, 17 Feb 2008 22:49:11 +0100 [thread overview]
Message-ID: <200802172249.11896.rjw@sisk.pl> (raw)
In-Reply-To: <200802160042.18620.lenb@kernel.org>
On Saturday, 16 of February 2008, Len Brown wrote:
> yeah, i know.
>
> Linus personally created this one last week.
>
> We're waiting for him to cool off before we re-suggest a patch that actually works:-)
Well, perhaps something like the appended one?
Thanks,
Rafael
---
arch/x86/kernel/acpi/sleep.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6/arch/x86/kernel/acpi/sleep.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/sleep.c
+++ linux-2.6/arch/x86/kernel/acpi/sleep.c
@@ -52,7 +52,7 @@ int acpi_save_state_mem(void)
header->video_mode = saved_video_mode;
#ifndef CONFIG_64BIT
- store_gdt(&header->pmode_gdt);
+ store_gdt((struct desc_ptr *)&header->pmode_gdt);
header->pmode_efer_low = nx_enabled;
if (header->pmode_efer_low & 1) {
@@ -68,8 +68,8 @@ int acpi_save_state_mem(void)
header->real_magic = 0x12345678;
#ifndef CONFIG_64BIT
- header->pmode_entry = &wakeup_pmode_return;
- header->pmode_cr3 = swsusp_pg_dir - __PAGE_OFFSET;
+ header->pmode_entry = (u32)&wakeup_pmode_return;
+ header->pmode_cr3 = (u32)(swsusp_pg_dir - __PAGE_OFFSET);
saved_magic = 0x12345678;
#else /* CONFIG_64BIT */
header->trampoline_segment = setup_trampoline() >> 4;
next prev parent reply other threads:[~2008-02-17 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 4:47 i386 warnings in acpi-test Andrew Morton
2008-02-16 5:42 ` Len Brown
2008-02-17 21:49 ` Rafael J. Wysocki [this message]
2008-02-21 7:49 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802172249.11896.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox