Re: 2.6.25-rc2-mm1 (x64 thermal build failure)

Andrew Morton
2008-02-19T23:23:13Z

On Tue, 19 Feb 2008 16:55:02 +0100 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Le Mon, 18 Feb 2008 04:13:40 -0800,
> Andrew Morton <akpm@linux-foundation.org> a __crit :
>
> > Option 3 wold be to add more #ifdef CONFIG_DMI lines around the
> > place. How ugly would that get?
>
> Like the attached patch. #ifdef CONFIG_DMI everywhere :-(
>

ug, sorry, if I'd realised it was like this I'd have said "don't bother".
Apart from the obvious problem, this means that people will keep breaking
CONFIG_DMI=n all the time, because they will forget the ifdefs, and the
number of people who test with CONFIG_DMI=n will be small.