Re: 2.6.25-rc2-mm1 (x64 thermal build failure)

Andrew Morton
2008-02-17T05:44:36Z

On Sat, 16 Feb 2008 21:16:03 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Sat, 16 Feb 2008 00:25:22 -0800 Andrew Morton wrote:
>
> >
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc2/2.6.25-rc2-mm1/
>
> ACPI is enabled, but DMI=n.
>
> linux-2.6.25-rc2-mm1/drivers/acpi/thermal.c: In function 'acpi_thermal_init':
> linux-2.6.25-rc2-mm1/drivers/acpi/thermal.c:1792: error: 'thermal_dmi_table' undeclared (first use in this function)
> linux-2.6.25-rc2-mm1/drivers/acpi/thermal.c:1792: error: (Each undeclared identifier is reported only once
> linux-2.6.25-rc2-mm1/drivers/acpi/thermal.c:1792: error: for each function it appears in.)
> make[3]: *** [drivers/acpi/thermal.o] Error 1
>

Bustage in x86-configurable-dmi-scanning-code.patch. Previously, DMI=y was
just hardwired. Now, it becomes selectable and stuff breaks.

I guess the DMI=n version of dmi_check_system() could become a macro so we
don't emit a reference to its argument, but that might generate
unused-variable warnings elsewhere.