From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green. Date: Wed, 20 Feb 2008 16:39:02 -0800 Message-ID: <200802201639.02502.jesse.barnes@intel.com> References: <200802201337.52247.jesse.barnes@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:17746 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758344AbYBUAzP (ORCPT ); Wed, 20 Feb 2008 19:55:15 -0500 In-Reply-To: Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jeff Chua Cc: Linus Torvalds , lkml , Dave Airlie , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, suspend-devel List , Greg KH On Wednesday, February 20, 2008 4:35 pm Jeff Chua wrote: > On Thu, Feb 21, 2008 at 5:37 AM, Jesse Barnes wrote: > > Ok, can you give this patch a try with the 'platform' method? It should > > at least tell us what ACPI would like the device to do at suspend time, > > but it probably won't fix the hang. > > I can't get it to compile. > > drivers/char/drm/i915_drv.c: In function 'i915_suspend': > drivers/char/drm/i915_drv.c:372: error: implicit declaration of > function 'acpi_pci_choose_state' Oops, maybe this should just be pci_choose_state instead. > drivers/char/drm/i915_drv.c: In function 'i915_resume': > drivers/char/drm/i915_drv.c:383: error: 'state' undeclared (first use > in this function) > drivers/char/drm/i915_drv.c:383: error: (Each undeclared identifier is > reported only once > drivers/char/drm/i915_drv.c:383: error: for each function it appears in.) And this change should just be reverted (leave it as PCI_D0). Thanks, Jesse