From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: 2.6.25-rc2 System no longer powers off after suspend-to-disk. Screen becomes green. Date: Wed, 20 Feb 2008 17:21:21 -0800 Message-ID: <200802201721.21353.jesse.barnes@intel.com> References: <200802201639.02502.jesse.barnes@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:1549 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbYBUBV2 (ORCPT ); Wed, 20 Feb 2008 20:21:28 -0500 In-Reply-To: Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jeff Chua Cc: Linus Torvalds , lkml , Dave Airlie , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, suspend-devel List , Greg KH On Wednesday, February 20, 2008 5:19 pm Jeff Chua wrote: > On Thu, Feb 21, 2008 at 8:39 AM, Jesse Barnes wrote: > > Oops, maybe this should just be pci_choose_state instead. > > And this change should just be reverted (leave it as PCI_D0). > > drivers/char/drm/i915_drv.c: In function 'i915_suspend': > drivers/char/drm/i915_drv.c:372: warning: passing argument 1 of > 'pci_choose_state' from incompatible pointer type > drivers/char/drm/i915_drv.c:373: warning: passing argument 1 of > 'pci_choose_state' from incompatible pointer type > > I hope those are just warning that can just be ignored. Oops again, should be dev->pdev. Silly DRM layer obfuscation. Jesse