public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Nish Aravamudan <nish.aravamudan@gmail.com>,
	Len Brown <lenb@kernel.org>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os
Date: Fri, 22 Feb 2008 11:25:04 -0800	[thread overview]
Message-ID: <20080222112504.04e6b6a9.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080222185648.GA6843@uranus.ravnborg.org>

Let's see what the ACPI people think about this change.

Thanks, Sam.
---
From: Randy Dunlap <randy.dunlap@oracle.com>

Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived
value, based on the value of ACPI_CUSTOM_DSDT_FILE (string).
Only the latter is presented to the user as a config option.

This fixes problems with "make randconfig" setting ACPI_CUSTOM_DSDT
but leaving ACPI_CUSTOM_DSDT_FILE empty/blank.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/acpi/Kconfig |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

--- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig
+++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig
@@ -283,24 +283,23 @@ config ACPI_TOSHIBA
 	  If you have a legacy free Toshiba laptop (such as the Libretto L1
 	  series), say Y.
 
-config ACPI_CUSTOM_DSDT
-	bool "Include Custom DSDT"
+config ACPI_CUSTOM_DSDT_FILE
+	string "Custom DSDT Table file to include"
+	default ""
 	depends on !STANDALONE
-	default n 
 	help
 	  This option supports a custom DSDT by linking it into the kernel.
 	  See Documentation/acpi/dsdt-override.txt
 
-	  If unsure, say N.
-
-config ACPI_CUSTOM_DSDT_FILE
-	string "Custom DSDT Table file to include"
-	depends on ACPI_CUSTOM_DSDT
-	default ""
-	help
 	  Enter the full path name to the file which includes the AmlCode
 	  declaration.
 
+	  If unsure, don't enter a file name.
+
+config ACPI_CUSTOM_DSDT
+	bool
+	default ACPI_CUSTOM_DSDT_FILE != ""
+
 config ACPI_CUSTOM_DSDT_INITRD
 	bool "Read Custom DSDT from initramfs"
 	depends on BLK_DEV_INITRD

  reply	other threads:[~2008-02-22 19:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080216002522.9c4bd0fb.akpm@linux-foundation.org>
2008-02-16 19:47 ` [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os Kamalesh Babulal
2008-02-16 20:01   ` Laura Garcia
2008-02-21  7:08   ` Len Brown
2008-02-21 18:54     ` Nish Aravamudan
2008-02-21 22:22       ` Sam Ravnborg
2008-02-22  1:38         ` Nish Aravamudan
2008-02-22 18:08           ` Sam Ravnborg
2008-02-22 18:12             ` Nish Aravamudan
2008-02-22 18:13             ` Randy Dunlap
2008-02-22 18:21               ` Nish Aravamudan
2008-02-22 18:27               ` Sam Ravnborg
2008-02-22 18:29                 ` Randy Dunlap
2008-02-22 18:56                   ` Sam Ravnborg
2008-02-22 19:25                     ` Randy Dunlap [this message]
2008-02-23  5:41                       ` [PATCH] " Len Brown
2008-02-23 15:33                       ` Kamalesh Babulal
2008-02-17  5:16 ` 2.6.25-rc2-mm1 (x64 thermal build failure) Randy Dunlap
2008-02-17  5:44   ` Andrew Morton
2008-02-18 10:15     ` Thomas Petazzoni
2008-02-18 12:13       ` Andrew Morton
2008-02-19 15:55         ` Thomas Petazzoni
2008-02-19 17:41           ` Randy Dunlap
2008-02-19 22:00             ` Thomas Petazzoni
2008-02-19 22:05               ` Randy Dunlap
2008-02-19 23:21           ` Andrew Morton
2008-02-20  7:21             ` Thomas Petazzoni
2008-02-20  9:55               ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080222112504.04e6b6a9.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nish.aravamudan@gmail.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox