public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Pavel Machek <pavel@ucw.cz>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PM: Handle unregistering devices during suspend/hibernation
Date: Fri, 22 Feb 2008 19:47:37 -0800	[thread overview]
Message-ID: <20080223034737.GA25876@suse.de> (raw)
In-Reply-To: <200802230219.28191.rjw@sisk.pl>

On Sat, Feb 23, 2008 at 02:19:27AM +0100, Rafael J. Wysocki wrote:
> On Saturday, 23 of February 2008, Rafael J. Wysocki wrote:
> > On Saturday, 23 of February 2008, Greg KH wrote:
> > > On Sat, Feb 23, 2008 at 12:53:11AM +0100, Rafael J. Wysocki wrote:
> > > > Hi Greg,
> > > > 
> > > > The appended patch fixes the issue with the new code for suspending/resuming
> > > > devices, related to the fact that some device drivers and CPU hotplug notifiers
> > > > unregister device objects while suspend is in progress, which leads to
> > > > deadlocks.
> > > > 
> > > > Please consider taking it for 2.6.25.
> 
> Ouch, please disregard this patch.
> 
> Alan rightfully noticed that it may confuse subsystems assuming that after
> device_unregister() has returned, the driver's ->release() method has run.
> 
> Unfortunately, he did that in a Bugzilla comment that has never reached
> my mailbox (strangely enough, I haven't been receiving any messages from
> the Bugzilla for the last two days or so).
> 
> Sorry for the trouble.

No problem at all.

thanks,

greg k-h

      reply	other threads:[~2008-02-23  3:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 23:53 [PATCH] PM: Handle unregistering devices during suspend/hibernation Rafael J. Wysocki
2008-02-23  0:02 ` Greg KH
2008-02-23  0:21   ` Rafael J. Wysocki
2008-02-23  1:19     ` Rafael J. Wysocki
2008-02-23  3:47       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080223034737.GA25876@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox