From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] PM: Handle unregistering devices during suspend/hibernation Date: Fri, 22 Feb 2008 19:47:37 -0800 Message-ID: <20080223034737.GA25876@suse.de> References: <200802230053.12180.rjw@sisk.pl> <20080223000222.GA26104@suse.de> <200802230121.50232.rjw@sisk.pl> <200802230219.28191.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cantor.suse.de ([195.135.220.2]:39322 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbYBWDpt (ORCPT ); Fri, 22 Feb 2008 22:45:49 -0500 Content-Disposition: inline In-Reply-To: <200802230219.28191.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Alan Stern , Pavel Machek , pm list On Sat, Feb 23, 2008 at 02:19:27AM +0100, Rafael J. Wysocki wrote: > On Saturday, 23 of February 2008, Rafael J. Wysocki wrote: > > On Saturday, 23 of February 2008, Greg KH wrote: > > > On Sat, Feb 23, 2008 at 12:53:11AM +0100, Rafael J. Wysocki wrote: > > > > Hi Greg, > > > > > > > > The appended patch fixes the issue with the new code for suspending/resuming > > > > devices, related to the fact that some device drivers and CPU hotplug notifiers > > > > unregister device objects while suspend is in progress, which leads to > > > > deadlocks. > > > > > > > > Please consider taking it for 2.6.25. > > Ouch, please disregard this patch. > > Alan rightfully noticed that it may confuse subsystems assuming that after > device_unregister() has returned, the driver's ->release() method has run. > > Unfortunately, he did that in a Bugzilla comment that has never reached > my mailbox (strangely enough, I haven't been receiving any messages from > the Bugzilla for the last two days or so). > > Sorry for the trouble. No problem at all. thanks, greg k-h