From: David Brownell <david-b@pacbell.net>
To: "Zhang, Rui" <rui.zhang@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [patch 2.6.25-rc2-git] crosslink ACPI and "real" device nodes
Date: Mon, 25 Feb 2008 22:45:43 -0800 [thread overview]
Message-ID: <200802252245.43282.david-b@pacbell.net> (raw)
In-Reply-To: <1203976028.10256.87.camel@acpi-hp-zz.sh.intel.com>
On Monday 25 February 2008, Zhang, Rui wrote:
> > + if (!ACPI_FAILURE(status)) {
> > + int ret;
> > +
> > + ret = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj,
> > + "firmware_node");
> > + ret = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj,
> > + "physical_node");
> > + }
>
> ret is not needed here...
But what compiler warnings do you see when you omit it? :)
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-02-26 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-23 5:54 [patch 2.6.25-rc2-git] crosslink ACPI and "real" device nodes David Brownell
2008-02-25 21:47 ` Zhang, Rui
2008-02-26 6:45 ` David Brownell [this message]
2008-02-25 22:10 ` Zhang, Rui
2008-02-26 7:17 ` David Brownell
2008-02-26 13:10 ` Henrique de Moraes Holschuh
2008-02-27 2:19 ` David Brownell
2008-03-08 19:47 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802252245.43282.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox