Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

Pavel Machek
2008-02-25T21:50:23Z

Hi!

> > > commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2
> > > Author: Pavel Machek <pavel@ucw.cz>
> > > Date: Thu Feb 21 13:56:55 2008 +0100
> > >
> > > power_state: get rid of write-only variable in SATA
> >
> > This is pretty unlikely to be it. Can you double check that this patch
> > really breaks something?
>
> I did and it seems to: just reverting
> 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 fixes resume for me.
> 635adc28087ced0c843d2ecb6d4ae474d0e611cd which is
> 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2~1
> also resumes fine.

Hmm, I guess that should teach me about "simple cleanups".

Do you use any of:

ata/sata_inic162x.c
ata/sata_nv.c
ata/sata_sil24.c

by chance?

(Ok, the patch is very safe to revert, it was "cleanup", it fixes
nothing).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html