Re: [patch 2.6.25-rc2-git] crosslink ACPI and "real" device nodes

[David Brownell <david-b@pacbell.net>]

On Monday 25 February 2008, Zhang, Rui wrote:
> 
> On Tue, 2008-02-26 at 14:45 +0800, David Brownell wrote:
> > On Monday 25 February 2008, Zhang, Rui wrote:
> > > > +       if (!ACPI_FAILURE(status)) {
> > > > +               int ret;
> > > > +
> > > > +               ret = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj,
> > > > +                               "firmware_node");
> > > > +               ret = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj,
> > > > +                               "physical_node");
> > > > +       }
> > >
> > > ret is not needed here...
> > 
> > But what compiler warnings do you see when you omit it?  :)
>
> I tried but NO warnings at all

Really???  In <linux/sysfs.h> I found:

int __must_check sysfs_create_link(struct kobject *kobj, struct kobject *target,
                                   const char *name);

Perhaps you disabled those warnings.  (And FWIW, I don't see any
reasonable way to handle such faults, so ignoring them is thus
the right "solution".)