Re: [PATCH] [repost] Make real parent for ACPI button input devices

[Andrey Borzenkov <arvidjaar@mail.ru>]

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Friday 29 February 2008, Andrew Morton wrote:
> On Thu, 28 Feb 2008 21:14:26 +0300 Andrey Borzenkov <arvidjaar@mail.ru> wrote:
> 
> > From: Andrey Borzenkov <arvidjaar@mail.ru>
> > 
> > Make sure input device for  ACPI button gets proper place
> > in device tree.
> > 
> > Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
> > 
> > ---
> > 
> >  drivers/acpi/button.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > 
> > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> > index 24a7865..6c5da83 100644
> > --- a/drivers/acpi/button.c
> > +++ b/drivers/acpi/button.c
> > @@ -449,6 +449,7 @@ static int acpi_button_add(struct acpi_device *device)
> >  	input->phys = button->phys;
> >  	input->id.bustype = BUS_HOST;
> >  	input->id.product = button->type;
> > +	input->dev.parent = &device->dev;
> >  
> >  	switch (button->type) {
> >  	case ACPI_BUTTON_TYPE_POWER:
> > 
> 
> What are the consequences of the bug which you've fixed?
> 

There is no direct negative impact; this is mostly cleanup that unifies
sysfs representation of ACPI input devices. The patch was submitted for
2.6.24-rc at the same time as similar patches for other ACPI input devices
but was lost for whatever reason.

> It helps very much if the changelog explains things like this so we can
> decide whether the patch is needed in 2.6.25 or even 2.6.24.x.
> 

I guess it can safely wait for post-2.6.25.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]