Re: [2.6 patch] acpi/battery.c: make 2 functions static

Ingo Molnar
2008-03-04T13:16:41Z

* Adrian Bunk <bunk@stusta.de> wrote:

> > well, i'm trying to assume the best, so please explain the following
> > sequence of events to me:
> >
> > 1) as you said you knew about this bug - which bug causes more inlining
> > overhead than hundreds of your uninlining patches combined. The bug
> > was introduced ~2 years ago in -mm - before the feature hit mainline
> > in v2.6.16.
>
> I don't remember having ever said this.
>
> Your choices are:
> [ ] prove your accusation that I said I
> "knew about this bug before the feature hit mainline"
> [ ] apologize
> [ ] be the firest person ever in my killfile

Adrian, you must be misunderstanding something. Where exactly in the
above sentences do i assert that you "knew about this bug before the
feature hit mainline"? I dont say that and cannot say that - and it's
rather irrelevant. All i say is that you knew about this bug for a long
time.

> >...
> > still, while you clearly had interest in this general area of the kernel
> > (for example you wrote hundreds of tiny uninlining patches that work
> > towards a similar goal),
>
> I'm not sure with whom you confuse me on this one.
> Perhaps with Ilpo?

i mean you send tons of trivial patches along the lines of:

| Author: Adrian Bunk <bunk@kernel.org>
| Date: Fri Feb 22 21:58:37 2008 +0200
|
| x86: don't make swapper_pg_pmd global

to reduce size of the kernel. At 50 bytes of image savings a pop, the
127,000 bytes savings my patch gives would be equivalent to more than
2500 of such patches of yours.

In other words: you knew about a bug that would have the same kernel
image size reduction equivalent to 2500 of your own tiny patches. Still
you didnt feel the need to pursue the issue?

I'm not sure about you, but that sure looks weird to me, and i'm really
curious what your interpretation of it is. (which, AFAICS, you have not
offered so far. You have rejected my common-sense explanation of your
actions rather forcefully, so logically there must be some other
explanation.)

Ingo