Re: [2.6 patch] acpi/battery.c: make 2 functions static

Adrian Bunk
2008-03-04T13:48:41Z

On Tue, Mar 04, 2008 at 02:16:00PM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@stusta.de> wrote:
>
> > > well, i'm trying to assume the best, so please explain the following
> > > sequence of events to me:
> > >
> > > 1) as you said you knew about this bug - which bug causes more inlining
> > > overhead than hundreds of your uninlining patches combined. The bug
> > > was introduced ~2 years ago in -mm - before the feature hit mainline
> > > in v2.6.16.
> >
> > I don't remember having ever said this.
> >
> > Your choices are:
> > [ ] prove your accusation that I said I
> > "knew about this bug before the feature hit mainline"
> > [ ] apologize
> > [ ] be the firest person ever in my killfile
>
> Adrian, you must be misunderstanding something. Where exactly in the
> above sentences do i assert that you "knew about this bug before the
> feature hit mainline"? I dont say that and cannot say that -

Please explain your statement "before the feature hit mainline in
v2.6.16" in the above sentence of you in a reasonable way other than
that it should say I knew about it before the feature hit mainline.

> and it's
> rather irrelevant.

Perhaps for you.

For me it's not irrelevant what I'm publically being accused of.

And it's not the first time in the thread that you use things that are
objectively not true in accusations against me.

> All i say is that you knew about this bug for a long
> time.
>...

I found the bug.

I repeatedly told about this bug on linux-kernel.

I explained to you who claimed just yesterday "my experience was that
it had effects." why it couldn't have possibly worked (no matter why
your experience was differently).

And now you start big flames against me why I hadn't stated more boldly
that this patch never worked.
Not against Arjan who seems to have sent a patch that never worked.
Not against Harvey who independently spotted the same bug.
Not against the people who didn't care when I said on linux-kernel that
it didn't work (one of the threads even had CONFIG_FORCED_INLINING in
the subject).

Thanks a lot, Mr. Molnar.

> Ingo

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed