Re: [2.6 patch] acpi/battery.c: make 2 functions static

Adrian Bunk
2008-03-03T14:55:50Z

On Mon, Mar 03, 2008 at 01:50:27PM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@kernel.org> wrote:
>
> > I can only repeat that I did state several times on linux-kernel that
> > it never worked.
> >
> > If you consider it my fault that noone reads my emails then you are
> > right that it's my fault...
>
> well, i'm trying to assume the best, so please explain the following
> sequence of events to me:
>
> 1) as you said you knew about this bug - which bug causes more inlining
> overhead than hundreds of your uninlining patches combined. The bug
> was introduced ~2 years ago in -mm - before the feature hit mainline
> in v2.6.16.

I don't remember having ever said this.

Your choices are:
[ ] prove your accusation that I said I
"knew about this bug before the feature hit mainline"
[ ] apologize
[ ] be the firest person ever in my killfile

>...
> still, while you clearly had interest in this general area of the kernel
> (for example you wrote hundreds of tiny uninlining patches that work
> towards a similar goal),

I'm not sure with whom you confuse me on this one.
Perhaps with Ilpo?

I have sending some bigger uninlining patches on my TODO list for quite
some time (since this is really the right thing to solve these issues),
but I've not yet gotten there.

> but strangely at the same time you neither
> fixed, nor properly escallated this _far_ bigger bug that causes +2.3%
> of text bloat on x86 [more than 120K of kernel text]. In fact:
>
> - you created bugzillas for far smaller bugs in the past, but you never
> created a bugzilla for this that i'm aware of.

I'm well aware of the fact that our Bugzilla is mostly a /dev/null for
the currently at about 1500 open bugs there.

That's why I tend [1] to only open bugs there for getting them into
Rafael's regression lists.

>...
> - you never said "this is a regression that should be fixed" to any of
> the regression lists.

This isn't a regression.

>...
> Ingo

cu
Adrian

[1] there are a few exceptions when I tried opening some bugs there

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed