Re: [2.6 patch] acpi/battery.c: make 2 functions static

Adrian Bunk
2008-03-03T09:13:14Z

On Mon, Mar 03, 2008 at 09:57:20AM +0100, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@kernel.org> wrote:
>
> > On Sat, Mar 01, 2008 at 09:26:41PM +0300, Alexey Starikovskiy wrote:
> > > May I keep them inline?
> >
> > The problem with such manual inlines is that we force gcc to always
> > inline them - and history has shown that functions grow without the
> > "inline" being removed.
>
> what do you mean by "we force gcc to always inline them"?

#define inline inline __attribute__((always_inline))

> gcc is free to decide whether to inline or to not inline.

Not with __attribute__((always_inline)).

> (and CONFIG_FORCED_INLINING got removed from 2.6.25)

CONFIG_FORCED_INLINING never had any effect.

> Ingo

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed