From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 4/4] ACPI PCI slot detection driver Date: Mon, 3 Mar 2008 21:49:27 -0800 Message-ID: <20080304054927.GA15566@suse.de> References: <20080229002341.GA21420@ldl.fc.hp.com> <20080229002938.GE21420@ldl.fc.hp.com> <20080301052542.GD19353@suse.de> <20080301144307.GD24386@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns2.suse.de ([195.135.220.15]:42340 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbYCDFxp (ORCPT ); Tue, 4 Mar 2008 00:53:45 -0500 Content-Disposition: inline In-Reply-To: <20080301144307.GD24386@parisc-linux.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthew Wilcox Cc: Alex Chiang , Gary Hade , kaneshige.kenji@jp.fujitsu.com, warthog19@eaglescrag.net, kristen.c.accardi@intel.com, rick.jones2@hp.com, linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-acpi@vger.kernel.org On Sat, Mar 01, 2008 at 07:43:07AM -0700, Matthew Wilcox wrote: > On Fri, Feb 29, 2008 at 09:25:42PM -0800, Greg KH wrote: > > What is the guarantee that the names of these slots are correct and do > > not happen to be the same as the hotpluggable ones? > > That would be a bug -- and yes, bugs happen, and we have to deal with > them. My main concern is that BIOS vendors will not fix these bugs, as no other OS cares/does this kind of thing today. The ammount of bad information out there might be quite large, and I think this was confirmed by some initial testing of IBM systems, right? > > Why show this information on machines that can not do anything with > > these slots at all? Will that not just confuse people? > > Only for people who think that /sys/bus/pci/slots/ is for hotpluggable > slots only. There is plenty of useful information available for slots > that aren't hotpluggable (eg bus address, speed, width, error status). Can the userspace tools that are using the existing directories thinking that only hotplug slots are there, handle "non-hotplug" slots showing up in this location? thanks, greg k-h