public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>,
	linux-acpi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: acer-wmi uses input:i8042_command() => build error
Date: Mon, 10 Mar 2008 16:06:49 -0700	[thread overview]
Message-ID: <20080310160649.5d225ac7.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0803102227540.18589@twin.jikos.cz>

On Mon, 10 Mar 2008 22:29:37 +0100 (CET) Jiri Kosina wrote:

> On Mon, 10 Mar 2008, Randy Dunlap wrote:
> 
> > drivers/built-in.o: In function `set_u32':
> > acer-wmi.c:(.text+0xb9bf6): undefined reference to `i8042_command'
> > make[1]: *** [vmlinux] Error 1
> > make: *** [sub-make] Error 2
> 
> Does the patch below fix your build?

Yes, thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>


> From: Jiri Kosina <jkosina@suse.cz>
> 
> Acer-wmi dependends on i8042 code.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> --- 
>  drivers/misc/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 982e27b..962817e 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -108,6 +108,7 @@ config ACER_WMI
>  	depends on ACPI
>  	depends on LEDS_CLASS
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on SERIO_I8042
>  	select ACPI_WMI
>  	---help---
>  	  This is a driver for newer Acer (and Wistron) laptops. It adds
> --

---
~Randy

  reply	other threads:[~2008-03-10 23:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 19:47 acer-wmi uses input:i8042_command() => build error Randy Dunlap
2008-03-10 19:59 ` Carlos Corbacho
2008-03-10 21:29   ` Jiri Kosina
2008-03-10 23:06     ` Randy Dunlap [this message]
2008-03-10 23:14       ` Carlos Corbacho
2008-03-10 23:16         ` Jiri Kosina
2008-03-12  7:03         ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080310160649.5d225ac7.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=carlos@strangeworlds.co.uk \
    --cc=jkosina@suse.cz \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox