From: Len Brown <lenb@kernel.org>
To: trenn@suse.de
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
"Zhang, Rui" <rui.zhang@intel.com>
Subject: Re: [PATCH 3/3] [2.6.25-rc5] Warn user about a BIOS bug in recent asus boards
Date: Wed, 12 Mar 2008 00:10:41 -0400 [thread overview]
Message-ID: <200803120010.41373.lenb@kernel.org> (raw)
In-Reply-To: <1205280392.8194.46.camel@linux-2bdv.site>
Applied.
thanks,
-Len
On Tuesday 11 March 2008, Thomas Renninger wrote:
> Warn user about a BIOS bug in recent asus boards
>
> Do copy passive devices only if they are valid.
>
> Signed-off-by: Thomas Renninger <trenn@suse.de>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
>
> ---
> drivers/acpi/thermal.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> Index: linux-2.6.24/drivers/acpi/thermal.c
> ===================================================================
> --- linux-2.6.24.orig/drivers/acpi/thermal.c
> +++ linux-2.6.24/drivers/acpi/thermal.c
> @@ -440,16 +440,18 @@ static int acpi_thermal_trips_update(str
> memset(&devices, 0, sizeof(struct acpi_handle_list));
> status = acpi_evaluate_reference(tz->device->handle, "_PSL",
> NULL, &devices);
> - if (ACPI_FAILURE(status))
> - tz->trips.passive.flags.valid = 0;
> - else
> + if (ACPI_SUCCESS(status)) {
> tz->trips.passive.flags.valid = 1;
> -
> - if (memcmp(&tz->trips.passive.devices, &devices,
> - sizeof(struct acpi_handle_list))) {
> - memcpy(&tz->trips.passive.devices, &devices,
> - sizeof(struct acpi_handle_list));
> - ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
> + if (memcmp(&tz->trips.passive.devices, &devices,
> + sizeof(struct acpi_handle_list))) {
> + memcpy(&tz->trips.passive.devices, &devices,
> + sizeof(struct acpi_handle_list));
> + ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
> + }
> + } else {
> + tz->trips.passive.flags.valid = 0;
> + ACPI_EXCEPTION((AE_INFO, status, "Invalid passiv trip"
> + " point\n"));
> }
> }
> if ((flag & ACPI_TRIPS_PASSIVE) || (flag & ACPI_TRIPS_DEVICES)) {
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2008-03-12 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 0:06 [PATCH 3/3] [2.6.25-rc5] Warn user about a BIOS bug in recent asus boards Thomas Renninger
2008-03-12 4:10 ` Len Brown [this message]
2008-03-12 5:40 ` Len Brown
2008-03-12 5:44 ` Zhang, Rui
2008-03-12 7:12 ` Zhang, Rui
2008-03-13 7:03 ` Zhang, Rui
2008-03-13 21:15 ` Németh Márton
2008-03-30 0:43 ` Yinghai Lu
2008-03-31 5:55 ` Németh Márton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803120010.41373.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox