Re: [PATCH 3/3] [2.6.25-rc5] Warn user about a BIOS bug in recent asus boards

[Len Brown <lenb@kernel.org>]

Actually,
This case (and others)
seems to be taken care of by Rui's recent patch for 8544, yes?

 [PATCH] ACPI: thermal fixup for broken BIOS which has invalid trip points

-Len

On Wednesday 12 March 2008, Len Brown wrote:
> Applied.
> 
> thanks,
> -Len
> 
> On Tuesday 11 March 2008, Thomas Renninger wrote:
> > Warn user about a BIOS bug in recent asus boards
> > 
> > Do copy passive devices only if they are valid.
> > 
> > Signed-off-by: Thomas Renninger <trenn@suse.de>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > 
> > ---
> >  drivers/acpi/thermal.c |   20 +++++++++++---------
> >  1 file changed, 11 insertions(+), 9 deletions(-)
> > 
> > Index: linux-2.6.24/drivers/acpi/thermal.c
> > ===================================================================
> > --- linux-2.6.24.orig/drivers/acpi/thermal.c
> > +++ linux-2.6.24/drivers/acpi/thermal.c
> > @@ -440,16 +440,18 @@ static int acpi_thermal_trips_update(str
> >  		memset(&devices, 0, sizeof(struct acpi_handle_list));
> >  		status = acpi_evaluate_reference(tz->device->handle, "_PSL",
> >  							NULL, &devices);
> > -		if (ACPI_FAILURE(status))
> > -			tz->trips.passive.flags.valid = 0;
> > -		else
> > +		if (ACPI_SUCCESS(status)) {
> >  			tz->trips.passive.flags.valid = 1;
> > -
> > -		if (memcmp(&tz->trips.passive.devices, &devices,
> > -				sizeof(struct acpi_handle_list))) {
> > -			memcpy(&tz->trips.passive.devices, &devices,
> > -				sizeof(struct acpi_handle_list));
> > -			ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
> > +			if (memcmp(&tz->trips.passive.devices, &devices,
> > +				   sizeof(struct acpi_handle_list))) {
> > +				memcpy(&tz->trips.passive.devices, &devices,
> > +				       sizeof(struct acpi_handle_list));
> > +				ACPI_THERMAL_TRIPS_EXCEPTION(flag, "device");
> > +			}
> > +		} else {
> > +			tz->trips.passive.flags.valid = 0;
> > +			ACPI_EXCEPTION((AE_INFO, status, "Invalid passiv trip"
> > +					" point\n"));
> >  		}
> >  	}
> >  	if ((flag & ACPI_TRIPS_PASSIVE) || (flag & ACPI_TRIPS_DEVICES)) {
> > 
> > 
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> 
>